Adds docker registry projects for localstack and minio #5593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to version the testcontainer images just like we version our other docker images. To ensure our local image names work, we need to inform testcontainers that they are in fact compatible images via `org.testcontainers.utility.DockerImageName#asCompatibleSubstituteFor`. A `Docker#localImageName` utility was added and propogated to locations where we previously manually constructing or hardcoding the "local-build" image names. Fixes deephaven#5592
devinrsmith
added
test
NoDocumentationNeeded
NoReleaseNotesNeeded
devinrsmith
requested review from
chipkent,
alexpeters1208,
rcaudy,
jmao-denver and
jcferretti
as code owners
niloc132
reviewed
Jun 11, 2024
niloc132
approved these changes
Jun 11, 2024
rcaudy
approved these changes
Jun 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to version the testcontainer images just like we version our other docker images.
To ensure our local image names work, we need to inform testcontainers that they are in fact compatible images via
org.testcontainers.utility.DockerImageName#asCompatibleSubstituteFor.A
Docker#localImageNameutility was added and propogated to locations where we previously manually constructing or hardcoding the "local-build" image names.Fixes #5592