pandas module for Pandas integration, fixes 1826 #1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmao-denver
force-pushed
the
feature-1826
branch
from
aae3edd
to
0fcf95a
Compare
chipkent
requested changes
Feb 7, 2022
jmao-denver
force-pushed
the
feature-1826
branch
from
53ecda7
to
adeb910
Compare
1. to_pandas() and to_table() to convert between DH tables and DF 2. test cases showed some lingering issues with DH NULL handling 3. performance is potentially an issue that has yet been addressed. Add an incomplete to_numpy() w/o 2d support also fixed some unit test failures Add multicolumns to numpy support also fix a DHError empty root cause issue Remove print statement in unit tests Minor improvement to DHError Respond to code review comments 1. Removed the remap parameter because users can always perform the value remapping using table operations which are way faster 2. Added or edited docstrings 3. Split the pandas module into pandas and numpy to avoid confusion 4. Increased test coverage 5. to_table in numpy remains to be done Address code review comments 1. optimizaiton around 2D numpy array generation 2. more code cleanup and docstring edit Resolve a merge conflict with base repo/main Add a test for suuport Pandas cat col in to_table
jmao-denver
force-pushed
the
feature-1826
branch
from
adeb910
to
a83a893
Compare
chipkent
previously requested changes
Feb 23, 2022
jjbrosnan
reviewed
Feb 24, 2022
jjbrosnan
reviewed
Feb 24, 2022
jjbrosnan
reviewed
Feb 24, 2022
jjbrosnan
approved these changes
Feb 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1826