Migrate the learn module to v2 #2010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipkent
previously requested changes
Feb 23, 2022
jjbrosnan
reviewed
Feb 23, 2022
jjbrosnan
reviewed
Feb 23, 2022
jjbrosnan
reviewed
Feb 23, 2022
jmao-denver
force-pushed
the
feature-2008
branch
from
2256ab7
to
59bf78e
Compare
jjbrosnan
approved these changes
Feb 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal refactoring
Todo: after #1919 is merged, bring back the sub tests depending on it in test_learn_gather.py
Fixes #2008