Refine Authentication apis, clarify deprecation and migration #2865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -99,12 +107,12 @@ message HandshakeRequest { | |||
| * - protocol = 0: most recent HandshakeResponse payload | |||
| * - protocol = 1: payload is BasicAuth | |||
| */ | |||
| sint32 auth_protocol = 1; | |||
| sint32 auth_protocol = 1 [deprecated=true]; | |||
There was a problem hiding this comment.
Is it possible to deprecate the whole HandshakeRequest object, or no?
There was a problem hiding this comment.
It appears not. I used the answer at https://stackoverflow.com/a/43380742/860630 to guide this change, and spam the "this is deprecated, plan on us removing it!" notices.
niloc132
commented
Sep 19, 2022
server/src/main/java/io/deephaven/server/session/SessionServiceGrpcImpl.java
Outdated
Show resolved
Hide resolved
niloc132
force-pushed
the
2564-authentication
branch
from
d961f2e
to
046bdd2
Compare
server/src/main/java/io/deephaven/server/session/SessionServiceGrpcImpl.java
Outdated
Show resolved
Hide resolved
nbauernfeind
approved these changes
Oct 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial #2564