Always half-close DoExchange snapshot requests #4632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial mitigation for deephaven#4627
rcaudy
previously approved these changes
Oct 12, 2023
nbauernfeind
previously approved these changes
Oct 12, 2023
|
Something is wrong with this, do not merge. |
|
Okay, I misremembered how we implemented hierarchical table data - this actually is a subscription and not snapshot based, so it was incorrect to half close right away. As far as I can tell, the java client is the only official client that used the snapshot api in this way - JS api is the only other consumer, and it already half-closed right away (...and doesn't use h2 anyway for DoExchange). |
rcaudy
approved these changes
Oct 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial mitigation for #4627