Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always half-close DoExchange snapshot requests #4632

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Always half-close DoExchange snapshot requests #4632

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
771af5c
Always half-close DoExchange snapshot requests
niloc132 Oct 12, 2023
3c033cd
Revert js api treetable change
niloc132 Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSnapshotImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,8 @@ public synchronized BarrageTable partialTable(RowSet viewport, BitSet columns, b
.setAppMetadata(ByteStringAccess.wrap(makeRequestInternal(viewport, columns, reverseViewport, options)))
.build());

observer.onCompleted();

while (!completed && exceptionWhileCompleting == null) {
// handle the condition where this function may have the exclusive lock
if (completedCondition != null) {
Expand All @@ -210,8 +212,6 @@ public synchronized BarrageTable partialTable(RowSet viewport, BitSet columns, b
}
}

observer.onCompleted();

if (exceptionWhileCompleting == null) {
return resultTable;
} else {
Expand Down
Loading