Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel subscribeToLogs and messageStream RPCs when the Session closes #5433

Merged
merged 5 commits into from
May 15, 2024

Commits on Apr 29, 2024

  1. Cancel subscribeToLogs and messageStream RPCs when the Session closes

    This PR fixes subscribeToLogs and messageStream RPCs; previously, they were staying open when a Session closed. Session closing behavior for a number of RPCs was specifically added as a tests here. I'll note that we are inconsistent in how we handle this case - some RPCs will complete successfully, others will pass along UNAUTHENTICATED or CANCELLED. We should aim to clean this up, but I'm proposing we do that as a follow-up PR to avoid PR bloat.
    
    The fix involves hooking into SessionServiceCallListener, which is a centralized place where we maintain Session state information. We should strongly consider migrating other RPC Session close behavior to here to simplify the implementations and maintain consistency. Again, I'd suggest doing that as a separate PR.
    
    Fixes deephaven#5415
    devinrsmith committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    5627a1b View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Simple renames

    devinrsmith committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    b84516f View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Configuration menu
    Copy the full SHA
    a2516a1 View commit details
    Browse the repository at this point in the history
  2. Move to server-test-utils

    devinrsmith committed May 15, 2024
    Configuration menu
    Copy the full SHA
    bd91bf2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6576a91 View commit details
    Browse the repository at this point in the history