Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: JS InputTable test failure and race #5616

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

niloc132
Copy link
Member

This test was slightly racy, able to fail other unrelated tests in some situations.

Follow-up to #5600

Copy link
Contributor

@AkshatJawne AkshatJawne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just curious for learning purposes, was there a reason for separating the test cases and then having multiple connections, instead of having the one big connection with a ton of .then() 's like we had discussed on slack?

@niloc132
Copy link
Member Author

Nope, either would have worked, this was quicker than stitching together the promises. The important thing is that each test method only finishes once.

@AkshatJawne
Copy link
Contributor

Ah, that makes sense, thanks!

@niloc132 niloc132 enabled auto-merge (squash) June 14, 2024 16:19
@niloc132 niloc132 merged commit e0b8ed8 into deephaven:main Jun 14, 2024
15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants