Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Modify key table viewport to only include key columns #5669

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

AkshatJawne
Copy link
Contributor

@AkshatJawne AkshatJawne commented Jun 25, 2024

@AkshatJawne AkshatJawne self-assigned this Jun 25, 2024
@AkshatJawne AkshatJawne changed the title fix: Modify key column viewport to not remove constituent column fix: Modify key table viewport to only include key columns Jun 25, 2024
mofojed
mofojed previously approved these changes Jun 25, 2024
niloc132
niloc132 previously approved these changes Jun 25, 2024
Copy link
Member

@niloc132 niloc132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but one requested change in wording to clarify what we're actually doing

@AkshatJawne AkshatJawne dismissed stale reviews from niloc132 and mofojed via e8d1458 June 26, 2024 01:17
@AkshatJawne
Copy link
Contributor Author

Changed label, will need re-approval

@mofojed mofojed enabled auto-merge (squash) June 26, 2024 13:18
@mofojed mofojed merged commit 77b6c1c into deephaven:main Jun 26, 2024
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants