-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Expose base, "underlying" table for Partitioned Table Enhancements #5645
fix: Expose base, "underlying" table for Partitioned Table Enhancements #5645
Conversation
Applying |
web/client-api/src/main/java/io/deephaven/web/client/api/JsPartitionedTable.java
Outdated
Show resolved
Hide resolved
Ready for re-review |
web/client-api/src/main/java/io/deephaven/web/client/api/JsPartitionedTable.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussing with @niloc132 a bit, there's a couple of changes we want to make.
- Main change - we want to deprecate the
getKeyTable
method, and instead the UI should be able to get the keys from thebaseTable
- Limit viewport to the key columns that matter when setting the viewport
- Means we don't create and subscribe to two tables unnecessarily, better performance
- To deprecate the method, we still need it to work - but instead of assigning
keys
table in therefetch
method, we want to lazily fetch it when thegetKeyTable()
method is called. Then UI has a bit of grace period before it needs to update
Will make changes here ( |
web/client-api/src/main/java/io/deephaven/web/client/api/JsPartitionedTable.java
Outdated
Show resolved
Hide resolved
web/client-api/src/main/java/io/deephaven/web/client/api/JsPartitionedTable.java
Outdated
Show resolved
Hide resolved
Looking into failures here |
Closes deephaven/web-client-ui#2079 (All the core changes,
web-client-ui
changes to come in corresponding PR)Changes Implemented
baseTable
member variable and have a corresponding getter method, in order to be able to expose it for Partitioned Tables, as desired in point 1 of this epic