Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: centralize optional server dependencies into plugin #5859

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

devinrsmith
Copy link
Member

This is a follow-up to #5850 that refactors all the optional dependencies into a centralized buildSrc plugin.

This is a follow-up to deephaven#5850 that refactors all the optional dependencies into a centralized buildSrc plugin.
@devinrsmith devinrsmith added this to the 0.36.0 milestone Jul 29, 2024
@devinrsmith devinrsmith self-assigned this Jul 29, 2024
rcaudy
rcaudy previously approved these changes Jul 29, 2024
Copy link
Member

@niloc132 niloc132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nit-picky - rename to optional-server-runtime-dependencies, or something (drop runtime? or server?) like that? We have other optional dependencies (brotli is the main one i can think of off the top of my head).

@devinrsmith devinrsmith enabled auto-merge (squash) July 30, 2024 14:44
@devinrsmith devinrsmith changed the title refactor: centralize runtime optional dependencies into plugin refactor: centralize optional server dependencies into plugin Jul 30, 2024
@devinrsmith devinrsmith enabled auto-merge (squash) July 30, 2024 14:45
@devinrsmith devinrsmith merged commit df8a9ab into deephaven:main Jul 30, 2024
16 checks passed
@devinrsmith devinrsmith deleted the optional-dependencies branch July 30, 2024 15:07
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2024
Copy link
Member

@niloc132 niloc132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approval after the fact

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants