Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update to Vite 4.3.5 #1279

Merged
merged 1 commit into from
May 16, 2023
Merged

build: Update to Vite 4.3.5 #1279

merged 1 commit into from
May 16, 2023

Conversation

mattrunyon
Copy link
Collaborator

Fixes #1209

Pulled the Vite dependency to the root since we use the same version in any apps like we do with TypeScript

@mattrunyon mattrunyon requested a review from mofojed May 8, 2023 23:42
@mattrunyon mattrunyon self-assigned this May 8, 2023
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #1279 (872690c) into main (588cb8f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1279   +/-   ##
=======================================
  Coverage   45.43%   45.43%           
=======================================
  Files         502      502           
  Lines       34764    34764           
  Branches     8679     8679           
=======================================
  Hits        15794    15794           
  Misses      18919    18919           
  Partials       51       51           
Flag Coverage Δ
unit 45.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was waiting for Vlad's merges, but this can probably go in whenever, no breaking changes

@mattrunyon
Copy link
Collaborator Author

I'll still wait b/c there will be a package-lock merge conflict

@mattrunyon mattrunyon merged commit d304300 into deephaven:main May 16, 2023
@mattrunyon mattrunyon deleted the vite-4.3 branch May 16, 2023 18:24
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Vite 4.3.0
2 participants