Skip to content

Commit

Permalink
chore: remove type embedding TODO from se_r serialize (#3845)
Browse files Browse the repository at this point in the history
Closes #3554. I just find `se_r` never supports type embedding. It's a
mistake in #3338.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Improved the serialization process by removing type embedding
handling, leading to cleaner and more maintainable code.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
  • Loading branch information
njzjz authored Jun 2, 2024
1 parent 42bf9f1 commit 6378f02
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions deepmd/tf/descriptor/se_r.py
Original file line number Diff line number Diff line change
Expand Up @@ -765,9 +765,6 @@ def serialize(self, suffix: str = "") -> dict:
raise NotImplementedError("spin is unsupported")
assert self.davg is not None
assert self.dstd is not None
# TODO: tf: handle type embedding in DescrptSeR.serialize
# not sure how to handle type embedding - type embedding is not a model parameter,
# but instead a part of the input data. Maybe the interface should be refactored...
return {
"@class": "Descriptor",
"type": "se_r",
Expand Down

0 comments on commit 6378f02

Please sign in to comment.