Feat: add se_r descriptor #3338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| data = data.copy() | ||
| variables = data.pop("@variables") | ||
| embeddings = data.pop("embeddings") | ||
| env_mat = data.pop("env_mat") |
Check notice
Code scanning / CodeQL
Unused local variable Note
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #3338 +/- ##
==========================================
+ Coverage 75.55% 75.61% +0.06%
==========================================
Files 408 410 +2
Lines 34247 34527 +280
Branches 1604 1604
==========================================
+ Hits 25876 26109 +233
- Misses 7510 7557 +47
Partials 861 861 ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
anyangml
commented
Feb 26, 2024
anyangml
commented
Feb 26, 2024
anyangml
commented
Feb 26, 2024
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
anyangml
commented
Feb 27, 2024
anyangml
commented
Feb 27, 2024
njzjz
reviewed
Feb 27, 2024
for more information, see https://pre-commit.ci
njzjz
approved these changes
Feb 27, 2024
Closed
njzjz
added a commit
to njzjz/deepmd-kit
that referenced
this pull request
May 31, 2024
Closes deepmodeling#3554. I just find `se_r` never supports type embedding. It's a mistake in deepmodeling#3338. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 2, 2024
Closes #3554. I just find `se_r` never supports type embedding. It's a mistake in #3338. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Improved the serialization process by removing type embedding handling, leading to cleaner and more maintainable code. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
mtaillefumier
pushed a commit
to mtaillefumier/deepmd-kit
that referenced
this pull request
Sep 18, 2024
) Closes deepmodeling#3554. I just find `se_r` never supports type embedding. It's a mistake in deepmodeling#3338. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Improved the serialization process by removing type embedding handling, leading to cleaner and more maintainable code. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to support
se_rdescriptor in pytorch and numpy.randa.tf.