Skip to content

Commit

Permalink
fix finetune RMSE and memory issue (#2860)
Browse files Browse the repository at this point in the history
Fix #2472. The previous implementation tried to allocate a (N, N) array
and the RMSE result was actually MAE instead.

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Han Wang <92130845+wanghan-iapcm@users.noreply.github.com>
Co-authored-by: Han Wang <92130845+wanghan-iapcm@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
  • Loading branch information
3 people authored Sep 25, 2023
1 parent ffe10f9 commit 67f30e0
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions deepmd/fit/ener.py
Original file line number Diff line number Diff line change
Expand Up @@ -856,9 +856,13 @@ def change_energy_bias(
delta_bias = np.linalg.lstsq(type_numbs, bias_diff, rcond=None)[0]
unbias_e = energy_predict + type_numbs @ delta_bias
atom_numbs = type_numbs.sum(-1)
rmse_ae = (
np.sqrt(np.square(unbias_e - energy_ground_truth)) / atom_numbs
).mean()
rmse_ae = np.sqrt(
np.mean(
np.square(
(unbias_e.ravel() - energy_ground_truth.ravel()) / atom_numbs
)
)
)
self.bias_atom_e[idx_type_map] += delta_bias.reshape(-1)
log.info(
f"RMSE of atomic energy after linear regression is: {rmse_ae} eV/atom."
Expand Down

0 comments on commit 67f30e0

Please sign in to comment.