fix finetune RMSE and memory issue #2860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix deepmodeling#2472. The previous implementation tried to allocate a (N, N) array and the RMSE result was actually MAE instead. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
njzjz
changed the title
njzjz
added a commit
to dptech-corp/deepmd-pytorch
that referenced
this pull request
Sep 24, 2023
The previous RMSE result was actually MAE instead. See also deepmodeling/deepmd-kit#2860.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## devel #2860 +/- ##
=======================================
Coverage 75.38% 75.38%
=======================================
Files 242 242
Lines 24424 24424
Branches 1580 1580
=======================================
Hits 18411 18411
Misses 5082 5082
Partials 931 931
☔ View full report in Codecov by Sentry. |
Co-authored-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu> Signed-off-by: Han Wang <92130845+wanghan-iapcm@users.noreply.github.com>
wanghan-iapcm
approved these changes
Sep 25, 2023
for more information, see https://pre-commit.ci
njzjz
added a commit
to dptech-corp/deepmd-pytorch
that referenced
this pull request
Sep 25, 2023
iProzd
pushed a commit
to dptech-corp/deepmd-pytorch
that referenced
this pull request
Oct 13, 2023
* fix finetune RMSE result The previous RMSE result was actually MAE instead. See also deepmodeling/deepmd-kit#2860. * apply changes in deepmodeling/deepmd-kit#2860
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2472. The previous implementation tried to allocate a (N, N) array and the RMSE result was actually MAE instead.