Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor the class for type embedding and dipole fitting #3545

Closed
github-actions bot opened this issue Mar 19, 2024 · 1 comment · Fixed by #3583
Closed

refactor the class for type embedding and dipole fitting #3545

github-actions bot opened this issue Mar 19, 2024 · 1 comment · Fixed by #3583
Assignees
@njzjz
Labels
branch: devel todo comment type: todo

Comments

@github-actions
Copy link

Line: 358

deepmd-kit//deepmd/tf/fit/dipole.py

Lines 355 to 365 in 76371ce

"dim_descrpt": self.dim_descrpt,
"embedding_width": self.dim_rot_mat_1,
# very bad design: type embedding is not passed to the class
# TODO: refactor the class for type embedding and dipole fitting
"mixed_types": False,
"dim_out": 3,
"neuron": self.n_neuron,
"resnet_dt": self.resnet_dt,
"activation_function": self.activation_function_name,
"precision": self.fitting_precision.name,
"exclude_types": [],

@njzjz njzjz self-assigned this Mar 21, 2024
@njzjz njzjz mentioned this issue Mar 21, 2024
Merged
@njzjz njzjz linked a pull request Mar 21, 2024 that will close this issue
tf: add explict mixed_types argument to fittings #3583
Merged
github-merge-queue bot pushed a commit that referenced this issue Mar 22, 2024
@njzjz
tf: add explict mixed_types argument to fittings (#3583)
a58dbc6 
Fix #3533. Fix #3542. Fix #3545. Fix #3546. Fix #3547. Fix #3548. Fix
#3549. Fix #3550.

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@github-actions GitHub Actions
Copy link
Author

Closed in commit a58dbc6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njzjz njzjz

Labels
branch: devel todo comment type: todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tf: add explict mixed_types argument to fittings njzjz/deepmd-kit
1 participant
@njzjz