Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tf: add explict mixed_types argument to fittings #3583

Merged

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Mar 21, 2024

Fix #3533. Fix #3542. Fix #3545. Fix #3546. Fix #3547. Fix #3548. Fix #3549. Fix #3550.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
deepmd/tf/fit/dos.py Fixed Show fixed Hide fixed
deepmd/tf/fit/ener.py Fixed Show fixed Hide fixed
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz marked this pull request as draft March 21, 2024 22:35
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz marked this pull request as ready for review March 21, 2024 22:44
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 90.19608% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 77.56%. Comparing base (fb61efb) to head (2a61e3c).

Files Patch % Lines
deepmd/tf/fit/dos.py 37.50% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3583      +/-   ##
==========================================
+ Coverage   77.54%   77.56%   +0.02%     
==========================================
  Files         432      432              
  Lines       37183    37203      +20     
  Branches     1620     1620              
==========================================
+ Hits        28832    28857      +25     
+ Misses       7490     7485       -5     
  Partials      861      861              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Mar 22, 2024
Merged via the queue into deepmodeling:devel with commit a58dbc6 Mar 22, 2024
48 checks passed
@njzjz njzjz mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment