Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This test for hybrid descriptor should be removed! #3560

Closed
github-actions bot opened this issue Mar 19, 2024 · 1 comment · Fixed by #3746
Closed

This test for hybrid descriptor should be removed! #3560

github-actions bot opened this issue Mar 19, 2024 · 1 comment · Fixed by #3746
Assignees
@iProzd
Labels
branch: devel todo comment type: todo
Milestone
v3.0.0

Comments

@github-actions
Copy link

Line: 120

deepmd-kit//source/tests/pt/model/test_descriptor_dpa2.py

Lines 117 to 127 in 76371ce

self.file_model_param = Path(CUR_DIR) / "models" / "dpa2.pth"
self.file_type_embed = Path(CUR_DIR) / "models" / "dpa2_tebd.pth"
# TODO This test for hybrid descriptor should be removed!
def test_descriptor_hyb(self):
# torch.manual_seed(0)
model_hybrid_dpa2 = self.model_json
dparams = model_hybrid_dpa2["descriptor"]
ntypes = len(model_hybrid_dpa2["type_map"])
dlist = dparams.pop("list")
des = DescrptBlockHybrid(

@njzjz njzjz added this to the v3.0.0 milestone Mar 19, 2024
@iProzd iProzd moved this from Ready to Backlog in DeePMD-3.0.0 beta release Apr 30, 2024
@iProzd iProzd mentioned this issue May 6, 2024
Merged
@iProzd iProzd linked a pull request May 6, 2024 that will close this issue
pt: remove old impl of DescrptBlockHybrid #3746
Merged
github-merge-queue bot pushed a commit that referenced this issue May 6, 2024
@iProzd
pt: remove old impl of DescrptBlockHybrid (#3746)
2438177 
Remove old impl of `DescrptBlockHybrid`, which was only used for old
impl of DPA2. Closes #3560

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Removed the `DescrptBlockHybrid` class and associated functionality
from the project.
- **Tests**
	- Updated tests to reflect the removal of `DescrptBlockHybrid` class.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@github-actions GitHub Actions
Copy link
Author

github-actions bot commented May 6, 2024

Closed in commit 2438177

@github-actions github-actions bot closed this as completed May 6, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in DeePMD-3.0.0 beta release May 6, 2024
mtaillefumier pushed a commit to mtaillefumier/deepmd-kit that referenced this issue Sep 18, 2024
@iProzd
pt: remove old impl of DescrptBlockHybrid (deepmodeling#3746)
86a6e4a 
Remove old impl of `DescrptBlockHybrid`, which was only used for old
impl of DPA2. Closes deepmodeling#3560

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Removed the `DescrptBlockHybrid` class and associated functionality
from the project.
- **Tests**
	- Updated tests to reflect the removal of `DescrptBlockHybrid` class.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iProzd iProzd

Labels
branch: devel todo comment type: todo
Projects
Multiple backend support for DeePMD-kit
Archived in project
DeePMD-3.0.0 beta release
Archived in project
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

pt: remove old impl of DescrptBlockHybrid iProzd/deepmd-kit
2 participants
@njzjz @iProzd