Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pt: remove old impl of DescrptBlockHybrid #3746

Merged
merged 2 commits into from
May 6, 2024

Conversation

iProzd
Copy link
Collaborator

@iProzd iProzd commented May 6, 2024

Remove old impl of DescrptBlockHybrid, which was only used for old impl of DPA2. Closes #3560

Summary by CodeRabbit

  • Refactor
    • Removed the DescrptBlockHybrid class and associated functionality from the project.
  • Tests
    • Updated tests to reflect the removal of DescrptBlockHybrid class.

@iProzd iProzd requested review from njzjz and wanghan-iapcm May 6, 2024 09:11
Copy link
Contributor

coderabbitai bot commented May 6, 2024

Walkthrough

The recent updates primarily involve the removal of the DescrptBlockHybrid class from the deepmd/pt/model/descriptor module, affecting both the Python and test files. This includes the elimination of related imports and methods across the affected files, streamlining the module by focusing on remaining functionalities.

Changes

Files Changes
.../descriptor/__init__.py
.../descriptor/hybrid.py
Removed DescrptBlockHybrid class and associated imports.
.../tests/pt/model/test_descriptor_dpa2.py Removed tests and imports for DescrptBlockHybrid. Retained test_descriptor method loading dpa2.json.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Python label May 6, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Out of diff range and nitpick comments (3)
deepmd/pt/model/descriptor/hybrid.py (3)

Line range hint 33-33: The parameter name list in the constructor conflicts with the built-in Python type list. Consider renaming it to avoid shadowing built-in names.


Line range hint 33-33: Consider simplifying the constructor by breaking down the complex logic into smaller, more manageable methods. This will improve readability and maintainability.


Line range hint 156-209: The forward method is complex and handles multiple scenarios. Consider adding more detailed comments to explain the logic, especially how different types of descriptors are handled.

@iProzd iProzd linked an issue May 6, 2024 that may be closed by this pull request
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.26%. Comparing base (d48f84a) to head (4592394).

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3746      +/-   ##
==========================================
+ Coverage   82.23%   82.26%   +0.03%     
==========================================
  Files         513      513              
  Lines       47745    47629     -116     
  Branches     2979     2981       +2     
==========================================
- Hits        39261    39182      -79     
+ Misses       7573     7536      -37     
  Partials      911      911              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz added this pull request to the merge queue May 6, 2024
Merged via the queue into deepmodeling:devel with commit 2438177 May 6, 2024
60 checks passed
mtaillefumier pushed a commit to mtaillefumier/deepmd-kit that referenced this pull request Sep 18, 2024
Remove old impl of `DescrptBlockHybrid`, which was only used for old
impl of DPA2. Closes deepmodeling#3560

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Removed the `DescrptBlockHybrid` class and associated functionality
from the project.
- **Tests**
	- Updated tests to reflect the removal of `DescrptBlockHybrid` class.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

This test for hybrid descriptor should be removed!
3 participants