-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pt: remove old impl of DescrptBlockHybrid
#3746
Conversation
WalkthroughThe recent updates primarily involve the removal of the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Out of diff range and nitpick comments (3)
deepmd/pt/model/descriptor/hybrid.py (3)
Line range hint
33-33
: The parameter namelist
in the constructor conflicts with the built-in Python typelist
. Consider renaming it to avoid shadowing built-in names.
Line range hint
33-33
: Consider simplifying the constructor by breaking down the complex logic into smaller, more manageable methods. This will improve readability and maintainability.
Line range hint
156-209
: Theforward
method is complex and handles multiple scenarios. Consider adding more detailed comments to explain the logic, especially how different types of descriptors are handled.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #3746 +/- ##
==========================================
+ Coverage 82.23% 82.26% +0.03%
==========================================
Files 513 513
Lines 47745 47629 -116
Branches 2979 2981 +2
==========================================
- Hits 39261 39182 -79
+ Misses 7573 7536 -37
Partials 911 911 ☔ View full report in Codecov by Sentry. |
Remove old impl of `DescrptBlockHybrid`, which was only used for old impl of DPA2. Closes deepmodeling#3560 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Removed the `DescrptBlockHybrid` class and associated functionality from the project. - **Tests** - Updated tests to reflect the removal of `DescrptBlockHybrid` class. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Remove old impl of
DescrptBlockHybrid
, which was only used for old impl of DPA2. Closes #3560Summary by CodeRabbit
DescrptBlockHybrid
class and associated functionality from the project.DescrptBlockHybrid
class.