-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cmake): fix OP_CXX_ABI_PT on macos/windows #3893
Conversation
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu> (cherry picked from commit 4c28b75)
WalkthroughWalkthroughA condition in the Changes
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #3893 +/- ##
========================================
Coverage 82.74% 82.74%
========================================
Files 518 519 +1
Lines 50215 50491 +276
Branches 2982 3017 +35
========================================
+ Hits 41548 41780 +232
- Misses 7757 7771 +14
- Partials 910 940 +30 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
`TORCH_CXX_FLAGS` on macOS and Windows doesn't have `_GLIBCXX_USE_CXX11_ABI`. This PR sets `OP_CXX_ABI_PT` to a default value to fix the error introduced in deepmodeling#3891. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated build configuration to set `OP_CXX_ABI_PT` conditionally for improved compatibility with macOS and Windows environments. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
TORCH_CXX_FLAGS
on macOS and Windows doesn't have_GLIBCXX_USE_CXX11_ABI
. This PR setsOP_CXX_ABI_PT
to a default value to fix the error introduced in #3891.Summary by CodeRabbit
OP_CXX_ABI_PT
conditionally for improved compatibility with macOS and Windows environments.