Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmake): fix OP_CXX_ABI_PT on macos/windows #3893

Merged
merged 2 commits into from
Jun 22, 2024
Merged

fix(cmake): fix OP_CXX_ABI_PT on macos/windows #3893

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1edd355
fix build on macos/windows
njzjz Jun 21, 2024
bd7da0b
prevent OP_CXX_ABI not defined
njzjz Jun 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions source/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,9 @@ if(ENABLE_PYTORCH AND NOT DEEPMD_C_ROOT)
set(OP_CXX_ABI ${CMAKE_MATCH_1})
add_definitions(-D_GLIBCXX_USE_CXX11_ABI=${OP_CXX_ABI})
endif()
else()
# Maybe in macos/windows
set(OP_CXX_ABI_PT ${OP_CXX_ABI})
njzjz marked this conversation as resolved.
Show resolved Hide resolved
endif()
# get torch directory get the directory of the target "torch"
get_target_property(_TORCH_LOCATION torch LOCATION)
Expand Down