Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove beir from the base GPU image #3692

Merged
merged 3 commits into from
Dec 13, 2022
Merged

fix: remove beir from the base GPU image #3692

merged 3 commits into from
Dec 13, 2022

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Dec 12, 2022

Related Issues

Proposed Changes:

How did you test it?

  • Manual testing of the images
  • Rebuilding the GPU image by hand from the PyTorch base image
  • Checking pip logs and beir deoendencies

Notes for the reviewer

@ArzelaAscoIi

Checklist

@ZanSara ZanSara requested a review from a team as a code owner December 12, 2022 09:57
@ZanSara ZanSara requested review from vblagoje and masci and removed request for a team and vblagoje December 12, 2022 09:57
@ArzelaAscoIi
Copy link
Member

Thanks for adding this 🤗

Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ZanSara ZanSara added this to the 1.12.0 milestone Dec 13, 2022
@ZanSara ZanSara merged commit f24cbdb into main Dec 13, 2022
@ZanSara ZanSara deleted the no-beir-in-gpu branch December 13, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:dependencies topic:docker topic:DX Developer Experience type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants