Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Docker images in CI #3696

Closed
ZanSara opened this issue Dec 12, 2022 · 2 comments
Closed

Test Docker images in CI #3696

ZanSara opened this issue Dec 12, 2022 · 2 comments
Assignees
Labels
P2 Medium priority, add to the next sprint if no P1 available topic:CI topic:docker

Comments

@ZanSara
Copy link
Contributor

ZanSara commented Dec 12, 2022

Problem
Right now, Docker images are not tested in CI. We test them manually before release, but this process is tedious and error-prone (see for example #3692)

Proposed solution
We should add a CI workflow that tests that the images are functional. For example we could start from a workflow that starts the REST API images and test the REST API respond on the /initialized endpoint.

@masci masci added the P2 Medium priority, add to the next sprint if no P1 available label Dec 19, 2022
@masci
Copy link
Contributor

masci commented Jan 16, 2023

Let's start with two basic tests:

  • Assert Haystack version docker run --rm deepset/haystack:base-gpu-v1.12.2 python -c"import haystack; print(haystack.__version__)" is 1.12.2
  • docker-compose up the default docker_compose.yml file and assert curl http://localhost:8000/hs_version returns the expeted version (something equivalent with a simpler setup would be better)

@silvanocerza
Copy link
Contributor

Fixed by #3943, #3976, #3982 and #4004.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Medium priority, add to the next sprint if no P1 available topic:CI topic:docker
Projects
None yet
Development

No branches or pull requests

3 participants