Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix docker image testing on release #3976

Merged
merged 1 commit into from
Jan 27, 2023
Merged

ci: Fix docker image testing on release #3976

merged 1 commit into from
Jan 27, 2023

Conversation

silvanocerza
Copy link
Contributor

Related Issues

Fixes failing CI like this case.

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added tests that demonstrate the correct behavior of the change
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@silvanocerza silvanocerza requested a review from a team as a code owner January 27, 2023 10:17
@silvanocerza silvanocerza self-assigned this Jan 27, 2023
@silvanocerza silvanocerza requested review from vblagoje and removed request for a team January 27, 2023 10:17
ZanSara
ZanSara approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@silvanocerza silvanocerza merged commit 7a36ccf into main Jan 27, 2023
@silvanocerza silvanocerza deleted the fix-docker-release-test branch January 27, 2023 11:05
@ZanSara ZanSara removed the request for review from vblagoje January 31, 2023 09:24
ZanSara pushed a commit that referenced this pull request Jan 31, 2023
@silvanocerza @ZanSara
Fix docker image testing on release (#3976)
a8d5fd0
@silvanocerza silvanocerza mentioned this pull request Jan 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZanSara ZanSara ZanSara approved these changes

Assignees

@silvanocerza silvanocerza

Labels
topic:CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silvanocerza @ZanSara