Simplifies and fix docker images tests on release #3982
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes:
Simplifies the docker images testing using a bash function and making it clearer what's the cause of the failure.
Also fixes an issue that was causing tests to always fail.
The
--platform
flag of thedocker run
command was set after the image name making it part of the command to run in the image instead of an option of thedocker run
command.How did you test it?
I ran the bash script locally, final test will be running in CI.
Notes for the reviewer
This will fix
docker_release.yml
failures inmain
like this one.Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.