Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifies and fix docker images tests on release #3982

Merged
merged 2 commits into from
Jan 30, 2023

Conversation

silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented Jan 27, 2023

Proposed Changes:

Simplifies the docker images testing using a bash function and making it clearer what's the cause of the failure.

Also fixes an issue that was causing tests to always fail.
The --platform flag of the docker run command was set after the image name making it part of the command to run in the image instead of an option of the docker run command.

How did you test it?

I ran the bash script locally, final test will be running in CI.

Notes for the reviewer

This will fix docker_release.yml failures in main like this one.

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added tests that demonstrate the correct behavior of the change
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@silvanocerza silvanocerza requested a review from a team as a code owner January 27, 2023 15:01
@silvanocerza silvanocerza self-assigned this Jan 27, 2023
@silvanocerza silvanocerza requested review from vblagoje and removed request for a team January 27, 2023 15:01
@silvanocerza
Copy link
Contributor Author

Merged in main to bring in PR #3983 to solve CI failures.

@masci
Copy link
Contributor

masci commented Jan 30, 2023

Also fixes an issue that was causing tests to always fail.

Which one? Can you expand a bit the PR description?

@silvanocerza
Copy link
Contributor Author

silvanocerza commented Jan 30, 2023

Which one? Can you expand a bit the PR description?

@masci updated it, should be clearer now. There's also a link to a failing workflow too.

Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of this much bash code in a yaml file, but it's ok for now 👍

@silvanocerza silvanocerza merged commit b4c5bb7 into main Jan 30, 2023
@silvanocerza silvanocerza deleted the fix-docker-images-testing branch January 30, 2023 13:48
@masci masci added this to the 1.13.0 milestone Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants