Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add Docker images testing #3943

Merged
merged 8 commits into from
Jan 27, 2023
Merged

ci: Add Docker images testing #3943

merged 8 commits into from
Jan 27, 2023

Conversation

silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented Jan 25, 2023

Related Issues

Solves #3696.

Proposed Changes:

Add steps during the Docker images release process to test they work correctly.

How did you test it?

I didn't test the workflow as it's not easily doable locally.

Notes for the reviewer

The tests are really minimal and only verify that the Haystack version returned is the one that we expect.

The versioned API images are not tested as of now.

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added tests that demonstrate the correct behavior of the change
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@silvanocerza silvanocerza requested a review from a team as a code owner January 25, 2023 13:29
@silvanocerza silvanocerza self-assigned this Jan 25, 2023
@silvanocerza silvanocerza requested review from mayankjobanputra and masci and removed request for a team January 25, 2023 13:29
@silvanocerza silvanocerza changed the title ci: Add workflow to test Docker images ci: Add Docker images testing Jan 25, 2023
@mayankjobanputra mayankjobanputra self-requested a review January 26, 2023 22:11
Copy link
Contributor

@mayankjobanputra mayankjobanputra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@silvanocerza silvanocerza merged commit a058365 into main Jan 27, 2023
@silvanocerza silvanocerza deleted the docker-image-testing branch January 27, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants