Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Delete Docker images after testing to prevent workflow failure #4004

Merged
merged 1 commit into from
Jan 30, 2023
Merged

ci: Delete Docker images after testing to prevent workflow failure #4004

merged 1 commit into from
Jan 30, 2023

Conversation

silvanocerza
Copy link
Contributor

Related Issues

N/A

Proposed Changes:

Remove Haystack Docker image after testing it to prevent GtiHub runner to fail because there is no space left.
See this workflow run as an example.

How did you test it?

Can't test it.

Notes for the reviewer

N/A

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added tests that demonstrate the correct behavior of the change
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@silvanocerza silvanocerza added this to the 1.13.0 milestone Jan 30, 2023
@silvanocerza silvanocerza self-assigned this Jan 30, 2023
@silvanocerza silvanocerza requested a review from a team as a code owner January 30, 2023 16:06
@silvanocerza silvanocerza requested review from sjrl and removed request for a team January 30, 2023 16:06
sjrl
sjrl approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and sounds good to me!

@silvanocerza silvanocerza merged commit 5f29c83 into main Jan 30, 2023
@silvanocerza silvanocerza deleted the docker-image-deletion branch January 30, 2023 16:57
ZanSara pushed a commit that referenced this pull request Jan 31, 2023
@silvanocerza @ZanSara
Delete Docker images after testing to prevent workflow failure (#4004)
a02d5f2
ZanSara added a commit that referenced this pull request Jan 31, 2023
@ZanSara
Revert "Delete Docker images after testing to prevent workflow failure (
c1f73fa 
#4004)"

This reverts commit a02d5f2.
ZanSara pushed a commit that referenced this pull request Jan 31, 2023
@silvanocerza @ZanSara
Delete Docker images after testing to prevent workflow failure (#4004)
2cff924
@silvanocerza silvanocerza mentioned this pull request Jan 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrl sjrl sjrl approved these changes

Assignees

@silvanocerza silvanocerza

Labels
None yet
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@silvanocerza @sjrl