Skip to content

Commit

Permalink
chore: error on max-params (#1782)
Browse files Browse the repository at this point in the history
## Description

There is currently only one maxParams error, should we go ahead and
enforce this with an error and then get this #1728 ready to merge with
deprecation warnings?

## Related Issue

Fixes #
<!-- or -->
Relates to #

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging
- [x] Unit,
[Journey](https://github.com/defenseunicorns/pepr/tree/main/journey),
[E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples),
[docs](https://github.com/defenseunicorns/pepr/tree/main/docs),
[adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or
updated as needed
- [x] [Contributor Guide
Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request)
followed

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Co-authored-by: Sam Mayer <sam.mayer@defenseunicorns.com>
  • Loading branch information
cmwylie19 and samayer12 authored Feb 10, 2025
1 parent b8ab147 commit 83b51e1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"eqeqeq": "error",
"max-depth": ["warn", { "max": 3 }],
"max-nested-callbacks": ["warn", { "max": 4 }],
"max-params": ["warn", { "max": 4 }],
"max-params": ["error", { "max": 4 }],
"max-statements": ["warn", { "max": 20 }, { "ignoreTopLevelFunctions": true }],
"no-invalid-this": "warn"
},
Expand Down

0 comments on commit 83b51e1

Please sign in to comment.