Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: error on max-params #1782

Merged
merged 4 commits into from
Feb 10, 2025
Merged

chore: error on max-params #1782

merged 4 commits into from
Feb 10, 2025

Conversation

cmwylie19
Copy link
Contributor

Description

There is currently only one maxParams error, should we go ahead and enforce this with an error and then get this #1728 ready to merge with deprecation warnings?

Related Issue

Fixes #

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.12%. Comparing base (f3e40bb) to head (65172f5).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1782   +/-   ##
=======================================
  Coverage   82.12%   82.12%           
=======================================
  Files          52       52           
  Lines        2215     2215           
  Branches      436      470   +34     
=======================================
  Hits         1819     1819           
+ Misses        394      367   -27     
- Partials        2       29   +27     

see 7 files with indirect coverage changes

@cmwylie19 cmwylie19 marked this pull request as ready for review February 7, 2025 19:41
@cmwylie19 cmwylie19 requested a review from a team as a code owner February 7, 2025 19:41
Copy link
Contributor

@samayer12 samayer12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with enforcing this as an error. If we need to support more params in a function this will force us to have a discussion around function design, which should pay off in the long-run.

@samayer12
Copy link
Contributor

Looks like format is blocked pending #1728

@samayer12
Copy link
Contributor

Now pending #1787

@samayer12 samayer12 enabled auto-merge February 10, 2025 17:09
@samayer12 samayer12 added this pull request to the merge queue Feb 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 10, 2025
@samayer12 samayer12 added this pull request to the merge queue Feb 10, 2025
Merged via the queue into main with commit 83b51e1 Feb 10, 2025
48 checks passed
@samayer12 samayer12 deleted the max-params branch February 10, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants