Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: max-params warning for src/sdk/sdk.ts #1787

Merged

Conversation

tamirazrab
Copy link
Contributor

Description

Resolve max-params warning for src/sdk/sdk.ts
...

End to End Test:
(See Pepr Excellent Examples)

Related Issue

Relates to #1700

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@tamirazrab tamirazrab requested a review from a team as a code owner February 10, 2025 12:46
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.12%. Comparing base (939e936) to head (bf8ecd3).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1787   +/-   ##
=======================================
  Coverage   82.11%   82.12%           
=======================================
  Files          52       52           
  Lines        2214     2215    +1     
  Branches      470      469    -1     
=======================================
+ Hits         1818     1819    +1     
- Misses        367      394   +27     
+ Partials       29        2   -27     
Files with missing lines Coverage Δ
src/sdk/sdk.ts 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

@samayer12 samayer12 added this pull request to the merge queue Feb 10, 2025
@samayer12 samayer12 mentioned this pull request Feb 10, 2025
5 tasks
Merged via the queue into defenseunicorns:main with commit f3e40bb Feb 10, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants