chore: 🐛 use reconcile to reduce thrash in pod watch and service watch #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
cmwylie19
changed the title
|
I opened a parallel PR to added reconcile for the service watch but not the pod one - #362. Might let this one simmer for a bit and see if it seems to help before pressing forward - thinking about the case here for our job termination...unless we are seeing duplicate attempts to terminate the sidecar, I'm not sure sequential/queue-based processing is needed here. |
|
no problem, we can close this. thanks! Close as you see fit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are watching for changes to the Kubernetes service and Neuvector Jobs in order to update network policy. This triggers a cascade of events on each change leading to likely thrash in the kube-apiserver. If we put them into a queue then they will be processes one at a time in the order in which the event came in. Cutting down the load on the API Server.
Visual Proof
Look at the wild spikes in CPU on the watcher. Now with this ordered processing, it seems to throttle the amount used and therefore is not hitting that strange frozen state.
See the issue for additional screenshots
52 mins no errors
First failure after 78 mins (memory seems to be growing)
Related Issue
Fixes - Hopefully 🤞 363
Relates to #363 defenseunicorns/pepr#745
Type of change
Checklist before merging