Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🐛 use reconcile to reduce thrash in pod watch and service watch #364

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pepr/istio/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ When(a.Pod)
.IsCreatedOrUpdated()
.WithLabel("batch.kubernetes.io/job-name")
.WithLabel("service.istio.io/canonical-name")
.Watch(async pod => {
.Reconcile(async pod => {
Log.info(
pod,
`Processing Pod ${pod.metadata?.namespace}/${pod.metadata?.name} for istio job termination`,
Expand Down
2 changes: 1 addition & 1 deletion src/pepr/operator/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ When(a.Service)
.IsCreatedOrUpdated()
.InNamespace("default")
.WithName("kubernetes")
.Watch(updateAPIServerCIDRFromService);
.Reconcile(updateAPIServerCIDRFromService);

// Watch for changes to the UDSPackage CRD and cleanup the namespace mutations
When(UDSPackage)
Expand Down
Loading