Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Approve sdc by Guid #156

Merged
merged 11 commits into from
Feb 7, 2023
Merged

Approve sdc by Guid #156

merged 11 commits into from
Feb 7, 2023

Conversation

VamsiSiddu-7
Copy link
Contributor

Description

Add support for Approve SDC operation from CSI-PowerFlex driver

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#402

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit Testing (Refer GitHub workflow for more details)
  • Functional Testing

preapproved-guid-node1

preapproved-guid-node2

JacobGros
JacobGros reviewed Feb 2, 2023
View reviewed changes
service/node.go Outdated Show resolved Hide resolved
JacobGros
JacobGros reviewed Feb 2, 2023
View reviewed changes
service/node.go Outdated Show resolved Hide resolved
bharathsreekanth
bharathsreekanth previously approved these changes Feb 2, 2023
View reviewed changes
service/features/get_system_instances.json Show resolved Hide resolved
service/service.go Show resolved Hide resolved
JacobGros
JacobGros reviewed Feb 2, 2023
View reviewed changes
service/node.go Outdated Show resolved Hide resolved
JacobGros
JacobGros previously approved these changes Feb 3, 2023
View reviewed changes
Copy link
Collaborator

@JacobGros JacobGros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ashleyvjoy
ashleyvjoy previously approved these changes Feb 6, 2023
View reviewed changes
JacobGros
JacobGros approved these changes Feb 6, 2023
View reviewed changes
Copy link
Collaborator

@JacobGros JacobGros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
are these changes coming to operator as well?

@VamsiSiddu-7
Copy link
Contributor Author

LGTM are these changes coming to operator as well?

yes jacob

@VamsiSiddu-7 VamsiSiddu-7 merged commit 11acdd1 into main Feb 7, 2023
@anandrajak1 anandrajak1 deleted the preapproved-guid branch October 17, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleyvjoy ashleyvjoy ashleyvjoy approved these changes

@bharathsreekanth bharathsreekanth bharathsreekanth approved these changes

@JacobGros JacobGros JacobGros approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VamsiSiddu-7 @JacobGros @bharathsreekanth @ashleyvjoy @khareRajshree