Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resize Powerpath devices #114

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Resize Powerpath devices #114

merged 1 commit into from
Aug 24, 2022

Conversation

boyamurthy
Copy link
Contributor

Update node.go for powerpath volume expansion

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#436

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

@delldubey delldubey changed the title Resize_powerpath_devices Resize Powerpath devices Aug 23, 2022
nidtara
nidtara approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@nidtara nidtara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@boyamurthy boyamurthy merged commit 9236acb into main Aug 24, 2022
@shanmydell shanmydell deleted the feature_436_powerpath_support branch November 18, 2022 05:29
santhoshhs10
santhoshhs10 reviewed Jul 13, 2023
View reviewed changes
Copy link
Contributor

@santhoshhs10 santhoshhs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

Sahiba-Gupta pushed a commit that referenced this pull request Oct 11, 2024
@boyamurthy @Sahiba-Gupta
Update node.go (#114)
48ebb8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santhoshhs10 santhoshhs10 santhoshhs10 left review comments

@shanmydell shanmydell shanmydell approved these changes

@nidtara nidtara nidtara approved these changes

@tssushma tssushma tssushma approved these changes

@bharadwajrs-dell bharadwajrs-dell Awaiting requested review from bharadwajrs-dell

@delldubey delldubey Awaiting requested review from delldubey

@mahesr2 mahesr2 Awaiting requested review from mahesr2

@mjsdell mjsdell Awaiting requested review from mjsdell

@prablr79 prablr79 Awaiting requested review from prablr79

@SinuChacko SinuChacko Awaiting requested review from SinuChacko

@shampavman shampavman Awaiting requested review from shampavman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@boyamurthy @shanmydell @santhoshhs10 @nidtara @tssushma