Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/nv me tcp nqn changes #47

Closed
wants to merge 19 commits into from
Closed

Conversation

harshitap26
Copy link
Contributor

@harshitap26 harshitap26 commented Jan 20, 2022

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#158

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

pkg/node/node.go Outdated Show resolved Hide resolved
pkg/node/node.go Show resolved Hide resolved
pkg/node/node.go Outdated
@@ -1239,13 +1285,16 @@ func (s *Service) buildInitiatorsArray(initiators []string) []gopowerstore.Initi
var portType gopowerstore.InitiatorProtocolTypeEnum
if s.useFC {
portType = gopowerstore.InitiatorProtocolTypeEnumFC
} else {
} else if !s.useFC && s.useISCSI {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!s.useFC check not needed here, as it is already in else if block

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes removed the !s.useFC condition from else if. Thanks

pkg/node/node.go Show resolved Hide resolved
@harshitap26 harshitap26 requested a review from spriya-m January 21, 2022 11:35
spriya-m
spriya-m previously approved these changes Jan 21, 2022
francis-nijay
francis-nijay previously approved these changes Jan 25, 2022
spriya-m
spriya-m previously approved these changes Jan 26, 2022
@harshitap26 harshitap26 dismissed stale reviews from spriya-m and francis-nijay via a21a5d5 January 27, 2022 06:05
@prablr79
Copy link
Collaborator

prablr79 commented Feb 3, 2022

@harshitap26 please do add the githubID for this feature.

harishp8889
harishp8889 previously approved these changes Feb 9, 2022
francis-nijay
francis-nijay previously approved these changes Feb 9, 2022
@harshitap26 harshitap26 force-pushed the feature/NVMe_TCP-NQN-Changes branch from e8f1f3a to 6ddc031 Compare February 10, 2022 07:21
@harshitap26 harshitap26 force-pushed the feature/NVMe_TCP-NQN-Changes branch from 870581e to 4024b38 Compare February 10, 2022 08:52
harishp8889
harishp8889 previously approved these changes Feb 11, 2022
github.com/onsi/ginkgo v1.16.5
github.com/onsi/gomega v1.18.1
github.com/onsi/ginkgo v1.14.2
github.com/onsi/gomega v1.10.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

versions of multiple packages have been downgraded. please check.

@@ -639,7 +661,7 @@ func (s *Service) NodeGetVolumeStats(ctx context.Context, req *csi.NodeGetVolume
}

// get volume metrics for mounted volume path
availableBytes, totalBytes, usedBytes, totalInodes, freeInodes, usedInodes, err := gofsutil.FsInfo(ctx, volumePath)
availableBytes, totalBytes, usedBytes, totalInodes, freeInodes, usedInodes, err := k8sutilfs.Info(volumePath)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should be calling gofsutil.FsInfo(), isnt it?

"github.com/dell/gopowerstore"
log "github.com/sirupsen/logrus"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/metadata"
"google.golang.org/grpc/status"
k8sutilfs "k8s.io/kubernetes/pkg/volume/util/fs"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

branch needs rebase

@harshitap26
Copy link
Contributor Author

Created a new PR for this

@harshitap26 harshitap26 deleted the feature/NVMe_TCP-NQN-Changes branch July 19, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants