-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/nv me tcp nqn changes #47
Conversation
pkg/node/node.go
Outdated
@@ -1239,13 +1285,16 @@ func (s *Service) buildInitiatorsArray(initiators []string) []gopowerstore.Initi | |||
var portType gopowerstore.InitiatorProtocolTypeEnum | |||
if s.useFC { | |||
portType = gopowerstore.InitiatorProtocolTypeEnumFC | |||
} else { | |||
} else if !s.useFC && s.useISCSI { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!s.useFC check not needed here, as it is already in else if block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes removed the !s.useFC condition from else if. Thanks
a21a5d5
@harshitap26 please do add the githubID for this feature. |
6ddc031
e8f1f3a
to
6ddc031
Compare
870581e
to
4024b38
Compare
github.com/onsi/ginkgo v1.16.5 | ||
github.com/onsi/gomega v1.18.1 | ||
github.com/onsi/ginkgo v1.14.2 | ||
github.com/onsi/gomega v1.10.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
versions of multiple packages have been downgraded. please check.
@@ -639,7 +661,7 @@ func (s *Service) NodeGetVolumeStats(ctx context.Context, req *csi.NodeGetVolume | |||
} | |||
|
|||
// get volume metrics for mounted volume path | |||
availableBytes, totalBytes, usedBytes, totalInodes, freeInodes, usedInodes, err := gofsutil.FsInfo(ctx, volumePath) | |||
availableBytes, totalBytes, usedBytes, totalInodes, freeInodes, usedInodes, err := k8sutilfs.Info(volumePath) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should be calling gofsutil.FsInfo(), isnt it?
"github.com/dell/gopowerstore" | ||
log "github.com/sirupsen/logrus" | ||
"google.golang.org/grpc/codes" | ||
"google.golang.org/grpc/metadata" | ||
"google.golang.org/grpc/status" | ||
k8sutilfs "k8s.io/kubernetes/pkg/volume/util/fs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
branch needs rebase
Created a new PR for this |
Description
A few sentences describing the overall goals of the pull request's commits.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration