Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/nv me tcp nqn changes #47

Closed
wants to merge 19 commits into from
Closed

Feature/nv me tcp nqn changes #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
03ab85c
gonvme changes
harshitap26 Feb 10, 2022
4024b38
gonvme changes
harshitap26 Feb 10, 2022
ef0d370
NodeGetInfo changes
harshitap26 Feb 10, 2022
2b62ca8
Merge branch 'main' into feature/NVMe_TCP-NQN-Changes
harshitap26 Feb 10, 2022
9eff279
Vetting checks
harshitap26 Feb 10, 2022
14779e7
Merge branch 'feature/NVMe_TCP-NQN-Changes' of github.com:dell/csi-po…
harshitap26 Feb 10, 2022
847ecd8
Vetting Checks
harshitap26 Feb 10, 2022
cd6024c
Vetting Checks
harshitap26 Feb 10, 2022
86cc1cb
Vetting Checks
harshitap26 Feb 10, 2022
29d3663
Vetting Checks
harshitap26 Feb 10, 2022
e05a933
latest gonvme
harshitap26 Feb 10, 2022
8245889
Vetting Checks
harshitap26 Feb 10, 2022
ecab3f2
Checks
harshitap26 Feb 10, 2022
dad4d64
Checks
harshitap26 Feb 10, 2022
e0310a9
Formatting Checks
harshitap26 Feb 10, 2022
0b59d91
Gonvme changes
harshitap26 Feb 16, 2022
d3cb7e0
NVMe TCP changes
harshitap26 Feb 16, 2022
ec92bfa
NVMe TCP changes
harshitap26 Feb 16, 2022
7484459
NVMe TCP changes
harshitap26 Feb 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dell-csi-helm-installer/verify-csi-powerstore.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ function verify-csi-powerstore() {
verify_alpha_snap_resources
verify_optional_replication_requirements
verify_iscsi_installation
verify_nvme_installation
verify_helm_3
}

Expand Down
28 changes: 28 additions & 0 deletions dell-csi-helm-installer/verify.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,34 @@ function header() {
echo "|- Kubernetes Version: ${kMajorVersion}.${kMinorVersion}"
}

# Check if the NVMe client is installed
function verify_nvme_installation() {
if [ ${NODE_VERIFY} -eq 0 ]; then
return
fi

log smart_step "Verifying NVMe installation" "$1"

error=0
for node in $MINION_NODES; do
# check if the NVMe client is installed
run_command ssh ${NODEUSER}@"${node}" "cat /etc/nvme/hostnqn" >/dev/null 2>&1
rv=$?
if [ $rv -ne 0 ]; then
error=1
found_warning "Either NVMe client was not found on node: $node or not able to verify"
fi
run_command ssh ${NODEUSER}@"${node}" lsmod | grep nvme_tcp &>/dev/null
rv=$?
if [ $rv -ne 0 ]; then
error=1
found_warning "Either NVMe module is not loaded on node: $node or not able to verify"
fi
done

check_error error
}

# Check if the iSCSI client is installed
function verify_iscsi_installation() {
if [ ${NODE_VERIFY} -eq 0 ]; then
Expand Down
27 changes: 19 additions & 8 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,24 +10,26 @@ require (
github.com/dell/dell-csi-extensions/volumeGroupSnapshot v1.0.0
github.com/dell/gobrick v1.2.0
github.com/dell/gocsi v1.5.0
github.com/dell/gofsutil v1.7.1-0.20220204052137-9928a2dc48d8
github.com/dell/gofsutil v1.6.0
github.com/dell/goiscsi v1.2.0
github.com/dell/gopowerstore v1.6.1-0.20211223095101-c47391fc979f
github.com/dell/gonvme v0.0.0-20220119211702-1dd63f6211d2
github.com/dell/gopowerstore v1.6.1-0.20220120132720-96c2320b69fe
github.com/fsnotify/fsnotify v1.4.9
github.com/golang/mock v1.4.4
github.com/golang/protobuf v1.5.2
github.com/grpc-ecosystem/go-grpc-middleware v1.0.1-0.20190118093823-f849b5445de4
github.com/onsi/ginkgo v1.16.5
github.com/onsi/gomega v1.18.1
github.com/onsi/ginkgo v1.14.2
github.com/onsi/gomega v1.10.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

versions of multiple packages have been downgraded. please check.

github.com/opentracing/opentracing-go v1.2.0
github.com/sirupsen/logrus v1.8.1
github.com/spf13/viper v1.7.1
github.com/stretchr/testify v1.7.0
github.com/uber/jaeger-client-go v2.25.0+incompatible
github.com/uber/jaeger-lib v2.4.0+incompatible
golang.org/x/net v0.0.0-20211015210444-4f30a5c0130f
golang.org/x/net v0.0.0-20210520170846-37e1c6afe023
google.golang.org/grpc v1.42.0
gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b
k8s.io/kubernetes v1.21.5
)

require (
Expand All @@ -38,6 +40,7 @@ require (
github.com/coreos/go-semver v0.3.0 // indirect
github.com/coreos/go-systemd/v22 v22.3.2 // indirect
github.com/davecgh/go-spew v1.1.1 // indirect
github.com/go-logr/logr v0.4.0 // indirect
github.com/go-openapi/errors v0.19.8 // indirect
github.com/go-openapi/strfmt v0.20.0 // indirect
github.com/go-stack/stack v1.8.0 // indirect
Expand All @@ -47,7 +50,7 @@ require (
github.com/magiconair/properties v1.8.1 // indirect
github.com/matttproud/golang_protobuf_extensions v1.0.2-0.20181231171920-c182affec369 // indirect
github.com/mitchellh/mapstructure v1.3.3 // indirect
github.com/nxadm/tail v1.4.8 // indirect
github.com/nxadm/tail v1.4.4 // indirect
github.com/pelletier/go-toml v1.7.0 // indirect
github.com/pkg/errors v0.9.1 // indirect
github.com/pmezard/go-difflib v1.0.0 // indirect
Expand All @@ -69,13 +72,21 @@ require (
go.uber.org/multierr v1.6.0 // indirect
go.uber.org/zap v1.17.0 // indirect
golang.org/x/sync v0.0.0-20210220032951-036812b2e83c // indirect
golang.org/x/sys v0.0.0-20211216021012-1d35b9e2eb4e // indirect
golang.org/x/text v0.3.7 // indirect
golang.org/x/sys v0.0.0-20210616094352-59db8d763f22 // indirect
golang.org/x/text v0.3.6 // indirect
golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1 // indirect
google.golang.org/genproto v0.0.0-20210602131652-f16073e35f0c // indirect
google.golang.org/protobuf v1.27.1 // indirect
gopkg.in/inf.v0 v0.9.1 // indirect
gopkg.in/ini.v1 v1.51.0 // indirect
gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7 // indirect
gopkg.in/yaml.v2 v2.4.0 // indirect
k8s.io/apimachinery v0.22.2 // indirect
k8s.io/apiserver v0.20.2 // indirect
k8s.io/component-base v0.20.2 // indirect
k8s.io/klog/v2 v2.9.0 // indirect
k8s.io/mount-utils v0.0.0 // indirect
k8s.io/utils v0.0.0-20210819203725-bdf08cb9a70a // indirect
)

replace (
Expand Down
Loading