Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature 756 unit test for unity support on csm operator #198

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Feature 756 unit test for unity support on csm operator #198

merged 1 commit into from
Apr 18, 2023

Conversation

rajendraindukuri
Copy link
Collaborator

@rajendraindukuri rajendraindukuri commented Apr 14, 2023 •
edited
Loading

Description

Contains Unit test coverage for the unity support added

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#756

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Ran unit tests on go 1.20 and all are passing
Driver pkg:
image

Controller pkg:
image

Note: All tests are passing . failures are due to not meeting the criteria by 0,5 % which we will cover as part of upcoming PR s

@rajendraindukuri rajendraindukuri force-pushed the feature-756-unit-test-for-unity-support-on-csm-operator branch 4 times, most recently from 47ed93d to 3cc90b1 Compare April 18, 2023 12:03
@panigs7 panigs7 mentioned this pull request Apr 18, 2023
Merged
8 tasks
@rajendraindukuri rajendraindukuri force-pushed the feature-756-unit-test-for-unity-support-on-csm-operator branch from 3cc90b1 to 950ea56 Compare April 18, 2023 13:28
@rajendraindukuri rajendraindukuri marked this pull request as ready for review April 18, 2023 16:12
panigs7
panigs7 previously approved these changes Apr 18, 2023
View reviewed changes
rensyct
rensyct previously approved these changes Apr 18, 2023
View reviewed changes
@rajendraindukuri rajendraindukuri force-pushed the feature-756-unit-test-for-unity-support-on-csm-operator branch from 236a6f7 to 0ac9281 Compare April 18, 2023 17:00
@rajendraindukuri rajendraindukuri merged commit 7275a0c into main Apr 18, 2023
@rensyct rensyct deleted the feature-756-unit-test-for-unity-support-on-csm-operator branch July 17, 2023 12:17
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
@ChristianAtDell
Unit test support for Unity support on CSM Operator (#198)
873d7f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panigs7 panigs7 panigs7 approved these changes

@rensyct rensyct rensyct approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rajendraindukuri @rensyct @panigs7 @meggm