Add Unity Driver Install Support in CSM Operator #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panigs7
requested review from
abhi16394,
mbasha-dell,
alikdell,
bharathsreekanth,
coulof,
Deepak-Ghivari,
gallacher,
JacobGros,
jooseppi-luna,
karthikk92,
kumarkgosa,
bandak2,
mjsdell,
rajendraindukuri,
rensyct,
tdawe,
shaynafinocchiaro,
atye and
sharmilarama
as code owners
10 tasks
bandak2
reviewed
Apr 18, 2023
samples/storage_csm_unity_v260.yaml
Outdated
| - name: CSI_LOG_LEVEL | ||
| value: "info" | ||
| - name: TENANT_NAME | ||
| value: "csi_unity_tenant" |
There was a problem hiding this comment.
maybe we can leave this empty?
karthikk92
reviewed
Apr 18, 2023
| return fmt.Errorf("%s %s not supported", csmv1.Unity, cr.Spec.Driver.ConfigVersion) | ||
| } | ||
| secrets := []string{config} | ||
|
|
There was a problem hiding this comment.
@panigs7 Can we have validations for certs along with the secrets created in the test-unity namespace? Since certs should be created mandatory to install the csi unity driver.
There was a problem hiding this comment.
@karthikk92 I will take care of this in another PR. Thanks for pointing it out!!
panigs7
force-pushed
the
feature-756-add-csi-unity-install-support
branch
from
6c3ae09 to
b32abad
Compare
panigs7
force-pushed
the
feature-756-add-csi-unity-install-support
branch
from
70fbeb9 to
f13b266
Compare
rensyct
approved these changes
Apr 18, 2023
rajendraindukuri
approved these changes
Apr 18, 2023
ChristianAtDell
added a commit
that referenced
this pull request
Oct 15, 2024
* csi-unity driver support in csm-operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the installation support for CSI Unity XT driver on CSM Operator.
Samples supported in this PR is only v2.6 CSI Unity
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Installation of CSM-Operator followed by CSI Unity Driver installation:
NOTE: The unit tests (#198) and e2e tests (#203) PR will be raised separately. Hence, the tests would fail currently