-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KRV-20573/csm status #446
KRV-20573/csm status #446
Conversation
@abhi16394 Is this PR just targeted for Observability and appmobility? For the other modules, CSM status functionality is already working as expected? |
@@ -291,6 +291,7 @@ func getTopology(op utils.OperatorConfig, cr csmv1.ContainerStorageModule) (stri | |||
} | |||
} | |||
|
|||
YamlString = strings.ReplaceAll(YamlString, CSMName, cr.Name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abhi16394 I saw you declared a variable "CSMName = """ in application_mobility.go . I don't see the same declaration in Observability.go and commonconfig.go. Will it append the attribute to yaml if it does not exist ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since the variable declaration is global and all other files come under package module,
We dont have to redeclare the variable "CSMName" again in other files.
pkg/utils/status.go
Outdated
log.Infof("daemonset expected [%d]", expected) | ||
log.Infof("daemonset nodeStatus.Available [%s]", nodeStatus.Available) | ||
//log.Infof("daemonset expected [%d]", expected) | ||
//log.Infof("daemonset nodeStatus.Available [%s]", nodeStatus.Available) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abhi16394 Why did you comment these log statements? They might be useful for debugging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uncommented the log statements
appEnabled = true | ||
appRunning, err = statusForAppMob(ctx, instance, r, newStatus) | ||
if err != nil { | ||
log.Infof("status for Application-Mobility err msg [%s]", err.Error()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abhi16394 Should these be error statements ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log comments should be fine
pkg/utils/status.go
Outdated
} | ||
} | ||
|
||
if(appEnabled && obsEnabled) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abhi16394 Are app_mobility and Observability interlinked ? Why cannot we make these checks independently and fail the status as and when we see a module failure ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed the code so that it will more reusable in future
now the scope for dreadnaught is just application-mobility, observability and authorization
since authorization is deployed as a sidecar container
we don't need to check that explicitly
we can add for more modules later
@abhi16394 Go lint, gosec checks are failing. Please take a look. Thanks! |
The lint error has been there from long time |
the scope of this defect is just for modules supported in dreadnaught |
//var appRunning bool | ||
//obsEnabled := false | ||
//var obsRunning bool | ||
//modrunning := false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need these commented out lines?
@abhi16394 can you merge this PR ? |
* add module status * Adding CSM Module status * Addressing the comments for PR * Making code reusable * Fix formatting issue * Resolving gosec issue
* Bump_up_csm-operator_version_to_1.4.1 (#434) * Patch version support (#433) * Adding support of v2.9.1 for Pmax, Pscale, PFlex and unity * Updating module config version for Pmax, Pscale, PFlex and unity * Update storage_csm_powerflex.yaml * version changed to 2.9.1 * version changed to 2.9.1 * Enabling github actions for all branch * updated version to 2.9.1 for unity, powerflex, powerscale and powermax * Adding the support of PStore v2.9.1 * Adding the support of PFlex v2.9.1 * Version bumpup replication 1.7.1 * Bump up version for authorization, resiliency * update csi-metadata-retriever version to 1.6.1 * update reverseproxy version to 2.8.1 --------- Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com> Co-authored-by: HarishH-DELL <harish.h2@dell.com> Co-authored-by: panigs7 <spandita.panigrahi@dell.com> * Update final manifests for posting of Operator 1.4.1 (#445) * Final manifest update and apex client (#447) * [bug-1120]: Update Authorization sidecar to use insecure flag (#442) * fix auth cert * remove constant * remove duplicate verbs * KRV-20573/csm status (#446) * add module status * Adding CSM Module status * Addressing the comments for PR * Making code reusable * Fix formatting issue * Resolving gosec issue --------- Co-authored-by: HarishH-DELL <109663924+HarishH-DELL@users.noreply.github.com> Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com> Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com> Co-authored-by: HarishH-DELL <harish.h2@dell.com> Co-authored-by: Chiman Jain <36687396+chimanjain@users.noreply.github.com> Co-authored-by: Aaron Tye <tyeaaron@gmail.com> Co-authored-by: abhi16394 <32352976+abhi16394@users.noreply.github.com>
* Add permissions for SC removal. (#431) * Bump_up_csm-operator_version_to_1.4.1 (#434) * Patch version support (#433) * Adding support of v2.9.1 for Pmax, Pscale, PFlex and unity * Updating module config version for Pmax, Pscale, PFlex and unity * Update storage_csm_powerflex.yaml * version changed to 2.9.1 * version changed to 2.9.1 * Enabling github actions for all branch * updated version to 2.9.1 for unity, powerflex, powerscale and powermax * Adding the support of PStore v2.9.1 * Adding the support of PFlex v2.9.1 * Version bumpup replication 1.7.1 * Bump up version for authorization, resiliency * update csi-metadata-retriever version to 1.6.1 * update reverseproxy version to 2.8.1 --------- Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com> Co-authored-by: HarishH-DELL <harish.h2@dell.com> Co-authored-by: panigs7 <spandita.panigrahi@dell.com> * Change namespace name to match documentation. (#437) * go-yaml version update (#438) * go-yaml version update * update go-yaml package to latest * remove extra verbs * remove duplicate verbs and add correct test files for resiliency UT --------- Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com> * [bug-1120]: Update Authorization sidecar to use insecure flag (#442) * fix auth cert * remove constant * remove duplicate verbs * reverting #426 changes (#444) * Update final manifests for posting of Operator 1.4.1 (#445) * KRV-20573/csm status (#446) * add module status * Adding CSM Module status * Addressing the comments for PR * Making code reusable * Fix formatting issue * Resolving gosec issue * Final manifest update and apex client (#447) * Add csm watch permissions. (#448) * Merged CSM Module Status * Fix App-Mob node error (#457) Co-authored-by: abhi16394 <abhi.muralidhara@dell.com> * Bump up CSM Operator version to 1.4.2 (#458) * update csm operator version to 1.4.2 * bump-up-op-version-1.4.2 * updated version in operator.yaml * adding missing arg to fix e2e * update authorization e2e (#459) * skip cert validation in e2e (#460) * Fixing FSGroupPolicy issue (#463) * Fixing FSGroupPolicy issue * Add unit test --------- Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com> * Fix for controller race, daemon status, and obs namespace (#464) * test controller state calc * add debug logs * check for driver * add daemonnset update * adds ns fix for when pod ns dis not csm ns * add ns check for daemon and deployment as well * fix typo * fix typo * explicitly return nil * add missing replace statements --------- Co-authored-by: grosnj1 <J.Grosner@emc.com> * Auth proxy status fix (#465) * actions * working on auth proxy status check * finished status check * fix 1 * fix or * code compiles * keep auth proxy out of daemonset check * trying to figure out deployment name * formatting * fix auth name in if condition * no daemonset * fix * added log statements * added another log statement * fix log statement * logs logs logs * compile * more logs * add logs and try updating status from handlesuccess * remove UpdateStatus call for now * adding csm label to auth * remove extraneous string replacement * removing commented code * Update actions.yml * fix merge issue * fix fmt * fix pscale + obs issue (#467) * fix some issues * fiix label issue, add debug logs * add more debug * more debugg lines * fix pscale issue * remmove debug logs * gofmt * set available to 0 en deployment is not checked * fix if check --------- Co-authored-by: grosnj1 <J.Grosner@emc.com> * update final manifests (#468) * fix vetting issues (#477) Co-authored-by: grosnj1 <J.Grosner@emc.com> --------- Co-authored-by: Don Khan <don.khan@dell.com> Co-authored-by: HarishH-DELL <109663924+HarishH-DELL@users.noreply.github.com> Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com> Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com> Co-authored-by: HarishH-DELL <harish.h2@dell.com> Co-authored-by: panigs7 <spandita.panigrahi@dell.com> Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com> Co-authored-by: Aaron Tye <tyeaaron@gmail.com> Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com> Co-authored-by: panigs7 <92028646+panigs7@users.noreply.github.com> Co-authored-by: abhi16394 <32352976+abhi16394@users.noreply.github.com> Co-authored-by: Chiman Jain <36687396+chimanjain@users.noreply.github.com> Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com> Co-authored-by: abhi16394 <abhi.muralidhara@dell.com> Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com> Co-authored-by: grosnj1 <J.Grosner@emc.com>
* Verified merge fixed release v1.4.2 (#479) * Add permissions for SC removal. (#431) * Bump_up_csm-operator_version_to_1.4.1 (#434) * Patch version support (#433) * Adding support of v2.9.1 for Pmax, Pscale, PFlex and unity * Updating module config version for Pmax, Pscale, PFlex and unity * Update storage_csm_powerflex.yaml * version changed to 2.9.1 * version changed to 2.9.1 * Enabling github actions for all branch * updated version to 2.9.1 for unity, powerflex, powerscale and powermax * Adding the support of PStore v2.9.1 * Adding the support of PFlex v2.9.1 * Version bumpup replication 1.7.1 * Bump up version for authorization, resiliency * update csi-metadata-retriever version to 1.6.1 * update reverseproxy version to 2.8.1 --------- Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com> Co-authored-by: HarishH-DELL <harish.h2@dell.com> Co-authored-by: panigs7 <spandita.panigrahi@dell.com> * Change namespace name to match documentation. (#437) * go-yaml version update (#438) * go-yaml version update * update go-yaml package to latest * remove extra verbs * remove duplicate verbs and add correct test files for resiliency UT --------- Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com> * [bug-1120]: Update Authorization sidecar to use insecure flag (#442) * fix auth cert * remove constant * remove duplicate verbs * reverting #426 changes (#444) * Update final manifests for posting of Operator 1.4.1 (#445) * KRV-20573/csm status (#446) * add module status * Adding CSM Module status * Addressing the comments for PR * Making code reusable * Fix formatting issue * Resolving gosec issue * Final manifest update and apex client (#447) * Add csm watch permissions. (#448) * Merged CSM Module Status * Fix App-Mob node error (#457) Co-authored-by: abhi16394 <abhi.muralidhara@dell.com> * Bump up CSM Operator version to 1.4.2 (#458) * update csm operator version to 1.4.2 * bump-up-op-version-1.4.2 * updated version in operator.yaml * adding missing arg to fix e2e * update authorization e2e (#459) * skip cert validation in e2e (#460) * Fixing FSGroupPolicy issue (#463) * Fixing FSGroupPolicy issue * Add unit test --------- Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com> * Fix for controller race, daemon status, and obs namespace (#464) * test controller state calc * add debug logs * check for driver * add daemonnset update * adds ns fix for when pod ns dis not csm ns * add ns check for daemon and deployment as well * fix typo * fix typo * explicitly return nil * add missing replace statements --------- Co-authored-by: grosnj1 <J.Grosner@emc.com> * Auth proxy status fix (#465) * actions * working on auth proxy status check * finished status check * fix 1 * fix or * code compiles * keep auth proxy out of daemonset check * trying to figure out deployment name * formatting * fix auth name in if condition * no daemonset * fix * added log statements * added another log statement * fix log statement * logs logs logs * compile * more logs * add logs and try updating status from handlesuccess * remove UpdateStatus call for now * adding csm label to auth * remove extraneous string replacement * removing commented code * Update actions.yml * fix merge issue * fix fmt * fix pscale + obs issue (#467) * fix some issues * fiix label issue, add debug logs * add more debug * more debugg lines * fix pscale issue * remmove debug logs * gofmt * set available to 0 en deployment is not checked * fix if check --------- Co-authored-by: grosnj1 <J.Grosner@emc.com> * update final manifests (#468) * fix vetting issues (#477) Co-authored-by: grosnj1 <J.Grosner@emc.com> --------- Co-authored-by: Don Khan <don.khan@dell.com> Co-authored-by: HarishH-DELL <109663924+HarishH-DELL@users.noreply.github.com> Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com> Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com> Co-authored-by: HarishH-DELL <harish.h2@dell.com> Co-authored-by: panigs7 <spandita.panigrahi@dell.com> Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com> Co-authored-by: Aaron Tye <tyeaaron@gmail.com> Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com> Co-authored-by: panigs7 <92028646+panigs7@users.noreply.github.com> Co-authored-by: abhi16394 <32352976+abhi16394@users.noreply.github.com> Co-authored-by: Chiman Jain <36687396+chimanjain@users.noreply.github.com> Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com> Co-authored-by: abhi16394 <abhi.muralidhara@dell.com> Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com> Co-authored-by: grosnj1 <J.Grosner@emc.com> * PR feedback --------- Co-authored-by: Don Khan <don.khan@dell.com> Co-authored-by: HarishH-DELL <109663924+HarishH-DELL@users.noreply.github.com> Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com> Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com> Co-authored-by: HarishH-DELL <harish.h2@dell.com> Co-authored-by: panigs7 <spandita.panigrahi@dell.com> Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com> Co-authored-by: Aaron Tye <tyeaaron@gmail.com> Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com> Co-authored-by: panigs7 <92028646+panigs7@users.noreply.github.com> Co-authored-by: abhi16394 <32352976+abhi16394@users.noreply.github.com> Co-authored-by: Chiman Jain <36687396+chimanjain@users.noreply.github.com> Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com> Co-authored-by: abhi16394 <abhi.muralidhara@dell.com> Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com> Co-authored-by: grosnj1 <J.Grosner@emc.com>
* Test branch (#482) * Verified merge fixed release v1.4.2 (#479) * Add permissions for SC removal. (#431) * Bump_up_csm-operator_version_to_1.4.1 (#434) * Patch version support (#433) * Adding support of v2.9.1 for Pmax, Pscale, PFlex and unity * Updating module config version for Pmax, Pscale, PFlex and unity * Update storage_csm_powerflex.yaml * version changed to 2.9.1 * version changed to 2.9.1 * Enabling github actions for all branch * updated version to 2.9.1 for unity, powerflex, powerscale and powermax * Adding the support of PStore v2.9.1 * Adding the support of PFlex v2.9.1 * Version bumpup replication 1.7.1 * Bump up version for authorization, resiliency * update csi-metadata-retriever version to 1.6.1 * update reverseproxy version to 2.8.1 --------- Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com> Co-authored-by: HarishH-DELL <harish.h2@dell.com> Co-authored-by: panigs7 <spandita.panigrahi@dell.com> * Change namespace name to match documentation. (#437) * go-yaml version update (#438) * go-yaml version update * update go-yaml package to latest * remove extra verbs * remove duplicate verbs and add correct test files for resiliency UT --------- Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com> * [bug-1120]: Update Authorization sidecar to use insecure flag (#442) * fix auth cert * remove constant * remove duplicate verbs * reverting #426 changes (#444) * Update final manifests for posting of Operator 1.4.1 (#445) * KRV-20573/csm status (#446) * add module status * Adding CSM Module status * Addressing the comments for PR * Making code reusable * Fix formatting issue * Resolving gosec issue * Final manifest update and apex client (#447) * Add csm watch permissions. (#448) * Merged CSM Module Status * Fix App-Mob node error (#457) Co-authored-by: abhi16394 <abhi.muralidhara@dell.com> * Bump up CSM Operator version to 1.4.2 (#458) * update csm operator version to 1.4.2 * bump-up-op-version-1.4.2 * updated version in operator.yaml * adding missing arg to fix e2e * update authorization e2e (#459) * skip cert validation in e2e (#460) * Fixing FSGroupPolicy issue (#463) * Fixing FSGroupPolicy issue * Add unit test --------- Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com> * Fix for controller race, daemon status, and obs namespace (#464) * test controller state calc * add debug logs * check for driver * add daemonnset update * adds ns fix for when pod ns dis not csm ns * add ns check for daemon and deployment as well * fix typo * fix typo * explicitly return nil * add missing replace statements --------- Co-authored-by: grosnj1 <J.Grosner@emc.com> * Auth proxy status fix (#465) * actions * working on auth proxy status check * finished status check * fix 1 * fix or * code compiles * keep auth proxy out of daemonset check * trying to figure out deployment name * formatting * fix auth name in if condition * no daemonset * fix * added log statements * added another log statement * fix log statement * logs logs logs * compile * more logs * add logs and try updating status from handlesuccess * remove UpdateStatus call for now * adding csm label to auth * remove extraneous string replacement * removing commented code * Update actions.yml * fix merge issue * fix fmt * fix pscale + obs issue (#467) * fix some issues * fiix label issue, add debug logs * add more debug * more debugg lines * fix pscale issue * remmove debug logs * gofmt * set available to 0 en deployment is not checked * fix if check --------- Co-authored-by: grosnj1 <J.Grosner@emc.com> * update final manifests (#468) * fix vetting issues (#477) Co-authored-by: grosnj1 <J.Grosner@emc.com> --------- Co-authored-by: Don Khan <don.khan@dell.com> Co-authored-by: HarishH-DELL <109663924+HarishH-DELL@users.noreply.github.com> Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com> Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com> Co-authored-by: HarishH-DELL <harish.h2@dell.com> Co-authored-by: panigs7 <spandita.panigrahi@dell.com> Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com> Co-authored-by: Aaron Tye <tyeaaron@gmail.com> Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com> Co-authored-by: panigs7 <92028646+panigs7@users.noreply.github.com> Co-authored-by: abhi16394 <32352976+abhi16394@users.noreply.github.com> Co-authored-by: Chiman Jain <36687396+chimanjain@users.noreply.github.com> Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com> Co-authored-by: abhi16394 <abhi.muralidhara@dell.com> Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com> Co-authored-by: grosnj1 <J.Grosner@emc.com> * PR feedback --------- Co-authored-by: Don Khan <don.khan@dell.com> Co-authored-by: HarishH-DELL <109663924+HarishH-DELL@users.noreply.github.com> Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com> Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com> Co-authored-by: HarishH-DELL <harish.h2@dell.com> Co-authored-by: panigs7 <spandita.panigrahi@dell.com> Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com> Co-authored-by: Aaron Tye <tyeaaron@gmail.com> Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com> Co-authored-by: panigs7 <92028646+panigs7@users.noreply.github.com> Co-authored-by: abhi16394 <32352976+abhi16394@users.noreply.github.com> Co-authored-by: Chiman Jain <36687396+chimanjain@users.noreply.github.com> Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com> Co-authored-by: abhi16394 <abhi.muralidhara@dell.com> Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com> Co-authored-by: grosnj1 <J.Grosner@emc.com> * add KUBE_NODE_NAME back in * add KUBE_NODE_NAME back in * add KUBE_NODE_NAME back into tests * Update dell-csm-operator.clusterserviceversion.yaml --------- Co-authored-by: Don Khan <don.khan@dell.com> Co-authored-by: HarishH-DELL <109663924+HarishH-DELL@users.noreply.github.com> Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com> Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com> Co-authored-by: HarishH-DELL <harish.h2@dell.com> Co-authored-by: panigs7 <spandita.panigrahi@dell.com> Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com> Co-authored-by: Aaron Tye <tyeaaron@gmail.com> Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com> Co-authored-by: panigs7 <92028646+panigs7@users.noreply.github.com> Co-authored-by: abhi16394 <32352976+abhi16394@users.noreply.github.com> Co-authored-by: Chiman Jain <36687396+chimanjain@users.noreply.github.com> Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com> Co-authored-by: abhi16394 <abhi.muralidhara@dell.com> Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com> Co-authored-by: grosnj1 <J.Grosner@emc.com>
* Bump_up_csm-operator_version_to_1.4.1 (#434) * Patch version support (#433) * Adding support of v2.9.1 for Pmax, Pscale, PFlex and unity * Updating module config version for Pmax, Pscale, PFlex and unity * Update storage_csm_powerflex.yaml * version changed to 2.9.1 * version changed to 2.9.1 * Enabling github actions for all branch * updated version to 2.9.1 for unity, powerflex, powerscale and powermax * Adding the support of PStore v2.9.1 * Adding the support of PFlex v2.9.1 * Version bumpup replication 1.7.1 * Bump up version for authorization, resiliency * update csi-metadata-retriever version to 1.6.1 * update reverseproxy version to 2.8.1 --------- Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com> Co-authored-by: HarishH-DELL <harish.h2@dell.com> Co-authored-by: panigs7 <spandita.panigrahi@dell.com> * Update final manifests for posting of Operator 1.4.1 (#445) * Final manifest update and apex client (#447) * [bug-1120]: Update Authorization sidecar to use insecure flag (#442) * fix auth cert * remove constant * remove duplicate verbs * KRV-20573/csm status (#446) * add module status * Adding CSM Module status * Addressing the comments for PR * Making code reusable * Fix formatting issue * Resolving gosec issue --------- Co-authored-by: HarishH-DELL <109663924+HarishH-DELL@users.noreply.github.com> Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com> Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com> Co-authored-by: HarishH-DELL <harish.h2@dell.com> Co-authored-by: Chiman Jain <36687396+chimanjain@users.noreply.github.com> Co-authored-by: Aaron Tye <tyeaaron@gmail.com> Co-authored-by: abhi16394 <32352976+abhi16394@users.noreply.github.com>
* Test branch (#482) * Verified merge fixed release v1.4.2 (#479) * Add permissions for SC removal. (#431) * Bump_up_csm-operator_version_to_1.4.1 (#434) * Patch version support (#433) * Adding support of v2.9.1 for Pmax, Pscale, PFlex and unity * Updating module config version for Pmax, Pscale, PFlex and unity * Update storage_csm_powerflex.yaml * version changed to 2.9.1 * version changed to 2.9.1 * Enabling github actions for all branch * updated version to 2.9.1 for unity, powerflex, powerscale and powermax * Adding the support of PStore v2.9.1 * Adding the support of PFlex v2.9.1 * Version bumpup replication 1.7.1 * Bump up version for authorization, resiliency * update csi-metadata-retriever version to 1.6.1 * update reverseproxy version to 2.8.1 --------- Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com> Co-authored-by: HarishH-DELL <harish.h2@dell.com> Co-authored-by: panigs7 <spandita.panigrahi@dell.com> * Change namespace name to match documentation. (#437) * go-yaml version update (#438) * go-yaml version update * update go-yaml package to latest * remove extra verbs * remove duplicate verbs and add correct test files for resiliency UT --------- Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com> * [bug-1120]: Update Authorization sidecar to use insecure flag (#442) * fix auth cert * remove constant * remove duplicate verbs * reverting #426 changes (#444) * Update final manifests for posting of Operator 1.4.1 (#445) * KRV-20573/csm status (#446) * add module status * Adding CSM Module status * Addressing the comments for PR * Making code reusable * Fix formatting issue * Resolving gosec issue * Final manifest update and apex client (#447) * Add csm watch permissions. (#448) * Merged CSM Module Status * Fix App-Mob node error (#457) Co-authored-by: abhi16394 <abhi.muralidhara@dell.com> * Bump up CSM Operator version to 1.4.2 (#458) * update csm operator version to 1.4.2 * bump-up-op-version-1.4.2 * updated version in operator.yaml * adding missing arg to fix e2e * update authorization e2e (#459) * skip cert validation in e2e (#460) * Fixing FSGroupPolicy issue (#463) * Fixing FSGroupPolicy issue * Add unit test --------- Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com> * Fix for controller race, daemon status, and obs namespace (#464) * test controller state calc * add debug logs * check for driver * add daemonnset update * adds ns fix for when pod ns dis not csm ns * add ns check for daemon and deployment as well * fix typo * fix typo * explicitly return nil * add missing replace statements --------- Co-authored-by: grosnj1 <J.Grosner@emc.com> * Auth proxy status fix (#465) * actions * working on auth proxy status check * finished status check * fix 1 * fix or * code compiles * keep auth proxy out of daemonset check * trying to figure out deployment name * formatting * fix auth name in if condition * no daemonset * fix * added log statements * added another log statement * fix log statement * logs logs logs * compile * more logs * add logs and try updating status from handlesuccess * remove UpdateStatus call for now * adding csm label to auth * remove extraneous string replacement * removing commented code * Update actions.yml * fix merge issue * fix fmt * fix pscale + obs issue (#467) * fix some issues * fiix label issue, add debug logs * add more debug * more debugg lines * fix pscale issue * remmove debug logs * gofmt * set available to 0 en deployment is not checked * fix if check --------- Co-authored-by: grosnj1 <J.Grosner@emc.com> * update final manifests (#468) * fix vetting issues (#477) Co-authored-by: grosnj1 <J.Grosner@emc.com> --------- Co-authored-by: Don Khan <don.khan@dell.com> Co-authored-by: HarishH-DELL <109663924+HarishH-DELL@users.noreply.github.com> Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com> Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com> Co-authored-by: HarishH-DELL <harish.h2@dell.com> Co-authored-by: panigs7 <spandita.panigrahi@dell.com> Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com> Co-authored-by: Aaron Tye <tyeaaron@gmail.com> Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com> Co-authored-by: panigs7 <92028646+panigs7@users.noreply.github.com> Co-authored-by: abhi16394 <32352976+abhi16394@users.noreply.github.com> Co-authored-by: Chiman Jain <36687396+chimanjain@users.noreply.github.com> Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com> Co-authored-by: abhi16394 <abhi.muralidhara@dell.com> Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com> Co-authored-by: grosnj1 <J.Grosner@emc.com> * PR feedback --------- Co-authored-by: Don Khan <don.khan@dell.com> Co-authored-by: HarishH-DELL <109663924+HarishH-DELL@users.noreply.github.com> Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com> Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com> Co-authored-by: HarishH-DELL <harish.h2@dell.com> Co-authored-by: panigs7 <spandita.panigrahi@dell.com> Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com> Co-authored-by: Aaron Tye <tyeaaron@gmail.com> Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com> Co-authored-by: panigs7 <92028646+panigs7@users.noreply.github.com> Co-authored-by: abhi16394 <32352976+abhi16394@users.noreply.github.com> Co-authored-by: Chiman Jain <36687396+chimanjain@users.noreply.github.com> Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com> Co-authored-by: abhi16394 <abhi.muralidhara@dell.com> Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com> Co-authored-by: grosnj1 <J.Grosner@emc.com> * add KUBE_NODE_NAME back in * add KUBE_NODE_NAME back in * add KUBE_NODE_NAME back into tests * Update dell-csm-operator.clusterserviceversion.yaml --------- Co-authored-by: Don Khan <don.khan@dell.com> Co-authored-by: HarishH-DELL <109663924+HarishH-DELL@users.noreply.github.com> Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com> Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com> Co-authored-by: HarishH-DELL <harish.h2@dell.com> Co-authored-by: panigs7 <spandita.panigrahi@dell.com> Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com> Co-authored-by: Aaron Tye <tyeaaron@gmail.com> Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com> Co-authored-by: panigs7 <92028646+panigs7@users.noreply.github.com> Co-authored-by: abhi16394 <32352976+abhi16394@users.noreply.github.com> Co-authored-by: Chiman Jain <36687396+chimanjain@users.noreply.github.com> Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com> Co-authored-by: abhi16394 <abhi.muralidhara@dell.com> Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com> Co-authored-by: grosnj1 <J.Grosner@emc.com>
Description
Issue - CSM Operator was not calculating status correctly when module is deployed with driver
It would show as succeeded even though module had failed
solution - the CSMstatus for moduleswas not implemented except application-mobility and incase of application-mobility it was thought as a standalone module which could be installed independent of driver. so it was not working when the same CR ws used to deploy driver and application-mobility
But the code has been changed to calculate the status of all supported modules in dreadnaught.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration