Make authorization proxy namespace configurable #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jooseppi-luna
requested review from
abhi16394,
mbasha-dell,
alikdell,
bharathsreekanth,
chimanjain,
coulof,
Deepak-Ghivari,
gallacher,
HarishH-DELL,
JacobGros,
karthikk92,
kumarkgosa,
bandak2,
mjsdell,
nitesh3108,
Prabhu-Dell,
rajendraindukuri,
rajkumar-palani,
shefali-malhotra,
panigs7 and
tdawe
as code owners
jooseppi-luna
requested review from
shaynafinocchiaro,
atye,
sharmilarama and
shanmydell
as code owners
alikdell
approved these changes
Feb 23, 2024
chimanjain
approved these changes
Feb 23, 2024
jooseppi-luna
added a commit
that referenced
this pull request
Feb 27, 2024
* use auth namespace for nginx deployment name * add test for auth proxy in different ns * get rid of hardcoded auth ns * Create csm_authorization_proxy_server_alt_ns.yaml * fixtests * update tests * fix auth proxy deployment --------- Co-authored-by: grosnj1 <J.Grosner@emc.com>
ChristianAtDell
added a commit
that referenced
this pull request
Oct 15, 2024
* use auth namespace for nginx deployment name * add test for auth proxy in different ns * get rid of hardcoded auth ns * Create csm_authorization_proxy_server_alt_ns.yaml * fixtests * update tests * fix auth proxy deployment --------- Co-authored-by: grosnj1 <J.Grosner@emc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The authorization proxy deployment had a few hardcoded namespaces that would cause the deployment to break if a user set a different namespace in a sample file. This PR fixes that and adds an e2e scenario to show that the changes work.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Ran e2e tests for authorization proxy server and a powerflex + authorization e2e test. All passing.