Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dell-replication-controller-config reconcile reset issue #755

Closed
wants to merge 12 commits into from
Closed

Fix dell-replication-controller-config reconcile reset issue #755

wants to merge 12 commits into from

Conversation

nitesh3108
Copy link
Contributor

@nitesh3108 nitesh3108 commented Oct 21, 2024 •
edited by ChristianAtDell
Loading

Closing due to rebase-error.

See PR #760

Description

Configmap (dell-replication-controller-config) is installed as part of the controller.yaml with empty values for clusterId and targets. Once we inject the cluster details using repctl cluster inject, the configmap is updated with the correct information. However, during the csm-operator reconcile loop, the configmap is getting reset, resulting in resetting the configmap.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1531

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran Replication e2e tests against powerscale driver and its successfully.
  • configmap once generated doesn't get overwritten with operator reconcile logic anymore.

ChristianAtDell
ChristianAtDell reviewed Oct 21, 2024
View reviewed changes
pkg/utils/status.go
@@ -116,6 +116,7 @@ func getDaemonSetStatus(ctx context.Context, instance *csmv1.ContainerStorageMod
}

for _, cluster := range clusterClients {
totalRunning = 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this totalRunning=0 do? Were we not resetting the count on each iteration of this for loop and needed to be? It doesn't seem related to other code changes in this PR, so it could just be an unrelated fix.

@ChristianAtDell
Copy link
Contributor

All checks pass (though I don't know how to fully interpret the Run yamllint step as completed other than it taking 18 seconds to run) and the code looks good to me.
image

However, Operator E2E tests have not been run on an image generated by these code changes, and I don't think such an E2E test will pass given the main branch is currently failing due to quay.io changes-in-progress.

@ChristianAtDell
Copy link
Contributor

image
A merge was made that didn't get signed when I ran a git pull to get latest changes-- my bad. Do you know of any way to sign that commit after-the-fact? Or do we need to do a rebase? All commits must be signed to merge into main on this repository. @nitesh3108

suryagupta4 and others added 8 commits October 22, 2024 12:38
@suryagupta4 @harishp8889 @ChristianAtDell
E2E for CSI-PowerMax driver with minimal CR (#749)
8dbc19e 
* feature/pmax-minimal-sample-e2e

* indentation fix

* yamllint fixes

* quay.io updates and some cleanup

* yamllint fixes

* add replica count

* add csipowermax-reverseproxy

* yamllint fixes

* added replication scenarios for powermax

---------

Co-authored-by: Harish P <harish_p4@dell.com>
@AkshaySainiDell @ChristianAtDell
Add UT for utils pkg (#751)
9ff3d12 
* Add Ut for HasModuleComponent & AddModuleComponent

* Refactor code and add UT for LoadDefaultComponents

* Refactor code and add more test cases

* Refactor code and add more test cases

* Fix error reported by golangci-lint
@harishp8889 @ChristianAtDell
Bugfix/reverseproxy (#752)
6c943e1 
* Removed latest version fetching through a function

* updated replication controller image to quayio

* quay image updates

* removed dead code
@chimanjain @ChristianAtDell
Add coordination.k8s.io apiGroups access for observability and update…
dcf3f8f 
… nginx image (#747)

* update nginxinc/nginx-unprivileged image

* add coordination.k8s.io access for observability

* bump trivy-action
@ashleyvjoy @harishp8889 @ChristianAtDell
Updating latest image references to quay.io (#750)
650bf4a 
* point latest images to quay.io

* point latest images to quay.io-tests folder

* point latest images to quay.io-tests folder

---------

Co-authored-by: Harish P <harishp8889@gmail.com>
Co-authored-by: Harish P <harish_p4@dell.com>
@meggm @atye @ChristianAtDell
E2E tests for PMax driver in minimal manifest file Auth v1 (#753)
25cc1b6 
* E2E tests for PMax driver in minimal manifest file Auth v1

Signed-off-by: meghana_gm <meghana.gm@dell.com>

* add powermax auth v2 testfile

* remove line

---------

Signed-off-by: meghana_gm <meghana.gm@dell.com>
Co-authored-by: Aaron Tye <tyeaaron@gmail.com>
@nitesh3108 @ChristianAtDell
standalone replication configmap
ce31e4f
@nitesh3108 @ChristianAtDell
create configmap
79db65b
@ChristianAtDell
Copy link
Contributor

Effort has been cherry-picked to PR #760 because of a failure to sign a merge commit and a rebase error.

@ashleyvjoy ashleyvjoy deleted the replication-test branch November 4, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianAtDell ChristianAtDell ChristianAtDell left review comments

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@chimanjain chimanjain Awaiting requested review from chimanjain chimanjain is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@gilltaran gilltaran Awaiting requested review from gilltaran gilltaran is a code owner

@harishp8889 harishp8889 Awaiting requested review from harishp8889 harishp8889 is a code owner

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL HarishH-DELL is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@meggm meggm Awaiting requested review from meggm meggm is a code owner

@mgandharva mgandharva Awaiting requested review from mgandharva mgandharva is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell Prabhu-Dell is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@shanmydell shanmydell Awaiting requested review from shanmydell shanmydell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@nitesh3108 @ChristianAtDell @suryagupta4 @AkshaySainiDell @harishp8889 @chimanjain @ashleyvjoy @meggm