Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dell-replication-controller-config reconcile reset issue #760

Merged
merged 15 commits into from
Oct 24, 2024

Conversation

ChristianAtDell
Copy link
Contributor

@ChristianAtDell ChristianAtDell commented Oct 22, 2024

Description

Configmap (dell-replication-controller-config) is installed as part of the controller.yaml with empty values for clusterId and targets. Once we inject the cluster details using repctl cluster inject, the configmap is updated with the correct information. However, during the csm-operator reconcile loop, the configmap is getting reset, resulting in resetting the configmap.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1531

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran Replication e2e tests against powerscale driver and its successfully.
  • configmap once generated doesn't get overwritten with operator reconcile logic anymore.
  • ran e2e tests with pscale, pflex, pmax, unity, pstore, and min e2e with replication flag, results uploaded internally

@ChristianAtDell
Copy link
Contributor Author

E2E Operator testing is in-progress, will not merge into main until that has passed.

Copy link
Contributor

@JacobGros JacobGros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChristianAtDell ChristianAtDell merged commit 5799506 into main Oct 24, 2024
7 checks passed
@ChristianAtDell ChristianAtDell deleted the replication-fixes-cherrypick branch October 24, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants