Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds resize for powerpath #19

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Adds resize for powerpath #19

merged 1 commit into from
Aug 24, 2022

Conversation

boyamurthy
Copy link
Contributor

Added volume expansion for powerpath devices

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#436

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
pp_expansion

nidtara
nidtara reviewed Aug 24, 2022
View reviewed changes
gofsutil_mount_linux.go
/* #nosec G204 */
checkCmd := "lsblk -P | awk '/mpath.+" + devID + "/ {print $0}'"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this choose either mpath or ppath devices based on the config.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes Nida , based on the device type we search the device name .

nidtara
nidtara approved these changes Aug 24, 2022
View reviewed changes
Copy link

@nidtara nidtara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@boyamurthy boyamurthy merged commit dde6dd5 into main Aug 24, 2022
@anandrajak1 anandrajak1 deleted the feature-436-powerpath branch October 17, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harishp8889 harishp8889 harishp8889 approved these changes

@shanmydell shanmydell shanmydell approved these changes

@nidtara nidtara nidtara approved these changes

@kumarp20 kumarp20 Awaiting requested review from kumarp20 kumarp20 is a code owner

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@francis-nijay francis-nijay Awaiting requested review from francis-nijay francis-nijay is a code owner

@spriya-m spriya-m Awaiting requested review from spriya-m

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@boyamurthy @harishp8889 @shanmydell @nidtara @delldubey