Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible 2.0 support? #22

Open
jkomara opened this issue Jan 27, 2016 · 19 comments
Open

ansible 2.0 support? #22

jkomara opened this issue Jan 27, 2016 · 19 comments
Assignees
Milestone

Comments

@jkomara
Copy link

jkomara commented Jan 27, 2016

Just came across this today and it looks awesome. I tried running it but it looks like it requires runner and the API was rewritten in 2.0, no longer using runner.

Are there any plans to support 2.0?

Thanks.

@ghost
Copy link

ghost commented Jan 27, 2016

👍 :)
Variable precedence has changed a bit in v2 as well, so there might need to be some mods for that.

@dellis23
Copy link
Owner

Unfortunately I'm not using Ansible much anymore, but I'd be happy to take a look at PRs with 2.0 support.

@jkomara
Copy link
Author

jkomara commented Jan 29, 2016

Are you using something else? Just curious what you decided to go with of you did.

On Wed, Jan 27, 2016 at 9:25 AM -0800, "Dan" notifications@github.com wrote:

Unfortunately I'm not using Ansible much anymore, but I'd be happy to take a look at PRs with 2.0 support.


Reply to this email directly or view it on GitHub.

@dellis23
Copy link
Owner

dellis23 commented Feb 8, 2016

@jkomara Sorry for the late response. I'm using puppet now. Though I have my beefs with Ansible, the primary reason I've changed is because my employer changed.

@steenzout
Copy link
Collaborator

@jkomara I've added a tox file ( #26 ) which should enable testing against ansible 2.0.

after the PR is merged I can do some work to make it 2.0 compatible.

@steenzout steenzout self-assigned this Apr 13, 2016
@steenzout steenzout added this to the v2.0.0 milestone Apr 13, 2016
@steenzout
Copy link
Collaborator

#28 addresses this issue.

when merged I'll close this.

@steenzout
Copy link
Collaborator

master branch has code to support Ansible 2.0.

a v2.0.0 will follow in a couple of days.

@jkomara
Copy link
Author

jkomara commented Apr 13, 2016

Awesome! Thank you.

_____________________________

From: Pedro Salgado notifications@github.com
Sent: Wednesday, April 13, 2016 13:38
Subject: Re: [dellis23/ansible-toolkit] ansible 2.0 support? (#22)
To: dellis23/ansible-toolkit ansible-toolkit@noreply.github.com
Cc: jkomara john.komara@gmail.com

Closed #22.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@opoplawski
Copy link

There are still two users of ansible.runner - show_vars.py and show_template.py:

Traceback (most recent call last):
  File "/bin/atk-show-vars", line 6, in <module>
    from ansible_toolkit.show_vars import show_vars
  File "/usr/lib/python2.7/site-packages/ansible_toolkit/show_vars.py", line 3, in <module>
    from ansible.runner import Runner
ImportError: No module named runner

@steenzout
Copy link
Collaborator

@opoplawski what ansible version are you using?

our tests are passing in ansible 1.9.4 and 2.0.1.0

@steenzout
Copy link
Collaborator

oh wait! don't know if the tests cover that code...

@opoplawski
Copy link

FWIW - ansible 2.0.2.0.

@steenzout
Copy link
Collaborator

tests don't cover the case above : reference here.

need to add tests for this and patch the code...

@steenzout
Copy link
Collaborator

working on this at issue-41 branch.

@opoplawski
Copy link

Okay, I'll keep an eye on that then. Still see 4 test failures on that branch at the moment.

@steenzout
Copy link
Collaborator

yes, I'm still working on this...

@sylr
Copy link

sylr commented May 24, 2017

Hi @steenzout, are you still working on that ?

@steenzout
Copy link
Collaborator

@sylr this ain't a priority for me anymore.

the current work on this is at this branch: https://github.com/dellis23/ansible-toolkit/tree/issue-41

feel free to PR.

@aioue
Copy link

aioue commented Sep 10, 2018

Needed the atk-vault functionality and don't have the python chops to update this code so instead borrowed heavily from this repo and extracted what I needed. Works with Ansible 2.6.

https://github.com/aioue/pilfer

Needs pathlib and ansible-vault pip packages and has a hardcoded vault password path right now but works the same way as atk-vault. Doesn't use the ansible libraries, but rather a 3rd party wrapper that is currently being supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants