Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox #26

Merged
merged 7 commits into from
Apr 13, 2016
Merged

tox #26

merged 7 commits into from
Apr 13, 2016

Conversation

steenzout
Copy link
Collaborator

  • added tox
  • ability to test against ansible 1.9.4 and 2.0.1.0
  • added travis-ci.org integration

@dellis23
Copy link
Owner

Thanks for this! I'm not sure I'll have the time to review it soon, as I already have a few PRs outstanding on this repo. Would you consider being a maintainer of the project for some period of time (however long you feel comfortable)? I don't use Ansible anymore, so it makes it a bit more difficult to robustly test.

@steenzout
Copy link
Collaborator Author

@dellis23 sure.
do you want to make a ansible-tookit org? or I just PR to this repo?
you can reach me at my github handle @saucelabs.com if you want to setup a call or chat.

I already had a few ideas on how to improve it and I was going to pursue them here since I saw a comment somewhere where you claimed you couldn't support it anymore.

As an example, I went through the ansible code and found a way where you could use ansible.cfg and therefore deprecate the need to have ~/.atk.

by the way, great work!

@steenzout steenzout mentioned this pull request Apr 12, 2016
@dellis23
Copy link
Owner

Thanks! I'll add you as a contributor on here so you can have access to merge PRs, close issues, etc. Do you also have a pypi account? I can look into giving you permissions to publish new versions on there as well.

@steenzout
Copy link
Collaborator Author

@dellis23 yes, I created one last week.
steenzout is my login.

I've setup travis-ci in the past to automatically upload new releases/tags into pypi (if they pass their tests) so I can do it for this repo as well.

@steenzout steenzout merged commit d59dcbf into dellis23:master Apr 13, 2016
@steenzout steenzout deleted the steenzout-tox branch April 13, 2016 01:54
@dellis23
Copy link
Owner

@steenzout I've added you as a maintainer on pypi. Thanks for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants