bugfix: Make sure vacuum works on relative paths #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjones127
commented
Jun 29, 2022
| .map(|rel_path| self.storage.join_path(&self.table_uri, rel_path)) | ||
| .collect::<Vec<_>>(); | ||
| match self.storage.delete_objs(paths).await { | ||
| match self.storage.delete_objs(&files_to_delete).await { |
There was a problem hiding this comment.
I'm not sure how this was working in object stores, but in local fs files_to_delete was already absolute. Local file system used Path::join(), which had the fortunate behavior of just using the second path if it was already absolute.
There was a problem hiding this comment.
well... maybe its not :) - will have a closer look once i get to #647.
roeap
approved these changes
Jun 29, 2022
| .map(|rel_path| self.storage.join_path(&self.table_uri, rel_path)) | ||
| .collect::<Vec<_>>(); | ||
| match self.storage.delete_objs(paths).await { | ||
| match self.storage.delete_objs(&files_to_delete).await { |
There was a problem hiding this comment.
well... maybe its not :) - will have a closer look once i get to #647.
n0gu
pushed a commit
to devsisters/delta-rs
that referenced
this pull request
Jul 13, 2022
* chore: create failing test showing vacuum doesn't work on relative paths * fix: don't needlessly join paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems that when we pass a relative path to
DeltaTable(), vacuum doesn't actually delete files. I've added tests in Python which is more convenient now that we have a writer.Related Issue(s)
Documentation