bugfix: Make sure vacuum works on relative paths (delta-io#664)

* chore: create failing test showing vacuum doesn't work on relative paths

* fix: don't needlessly join paths

python/tests/test_vacuum.py

@@ -0,0 +1,69 @@
+import os
+import pathlib
+
+import pyarrow as pa
+import pytest
+
+from deltalake import DeltaTable, write_deltalake
+
+
+def test_vacuum_dry_run_simple_table():
+    table_path = "../rust/tests/data/delta-0.2.0"
+    dt = DeltaTable(table_path)
+    retention_periods = 169
+    tombstones = dt.vacuum(retention_periods)
+    tombstones.sort()
+    assert tombstones == [
+        "../rust/tests/data/delta-0.2.0/part-00000-512e1537-8aaa-4193-b8b4-bef3de0de409-c000.snappy.parquet",
+        "../rust/tests/data/delta-0.2.0/part-00000-b44fcdb0-8b06-4f3a-8606-f8311a96f6dc-c000.snappy.parquet",
+        "../rust/tests/data/delta-0.2.0/part-00001-185eca06-e017-4dea-ae49-fc48b973e37e-c000.snappy.parquet",
+        "../rust/tests/data/delta-0.2.0/part-00001-4327c977-2734-4477-9507-7ccf67924649-c000.snappy.parquet",
+    ]
+
+    retention_periods = -1
+    with pytest.raises(Exception) as exception:
+        dt.vacuum(retention_periods)
+    assert str(exception.value) == "The retention periods should be positive."
+
+    retention_periods = 167
+    with pytest.raises(Exception) as exception:
+        dt.vacuum(retention_periods)
+    assert (
+        str(exception.value)
+        == "Invalid retention period, minimum retention for vacuum is configured to be greater than 168 hours, got 167 hours"
+    )
+
+
+@pytest.mark.parametrize("use_relative", [True, False])
+def test_vacuum_zero_duration(
+    tmp_path: pathlib.Path, sample_data: pa.Table, monkeypatch, use_relative: bool
+):
+    if use_relative:
+        monkeypatch.chdir(tmp_path)  # Make tmp_path the working directory
+        table_path = "./path/to/table"
+    else:
+        table_path = str(tmp_path)
+
+    write_deltalake(table_path, sample_data, mode="overwrite")
+    dt = DeltaTable(table_path)
+    original_files = set(dt.file_uris())
+    write_deltalake(table_path, sample_data, mode="overwrite")
+    dt.update_incremental()
+    new_files = set(dt.file_uris())
+    assert new_files.isdisjoint(original_files)
+
+    tombstones = set(dt.vacuum(retention_hours=0, enforce_retention_duration=False))
+    assert tombstones == original_files
+
+    tombstones = set(
+        dt.vacuum(retention_hours=0, dry_run=False, enforce_retention_duration=False)
+    )
+    assert tombstones == original_files
+
+    parquet_files = {
+        os.path.join(table_path, f)
+        for f in os.listdir(table_path)
+        if f.endswith("parquet")
+    }
+
+    assert parquet_files == new_files

rust/src/delta.rs

@@ -1197,12 +1197,7 @@ impl DeltaTable {
         if dry_run {
             return Ok(files_to_delete);
         }
-
-        let paths = &files_to_delete
-            .iter()
-            .map(|rel_path| self.storage.join_path(&self.table_uri, rel_path))
-            .collect::<Vec<_>>();
-        match self.storage.delete_objs(paths).await {
+        match self.storage.delete_objs(&files_to_delete).await {
             Ok(_) => Ok(files_to_delete),
             Err(err) => Err(DeltaTableError::StorageError { source: err }),
         }