Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cargo): update derive_more from 1.0.0-beta.6 to 1.0.0-beta.7 #5850

Closed
wants to merge 1 commit into from

Conversation

link2xt
Copy link
Collaborator

@link2xt link2xt commented Aug 3, 2024

This reproduces the problem described in https://support.delta.chat/t/rs-delta-chats-url/3211

@link2xt
Copy link
Collaborator Author

link2xt commented Aug 3, 2024

I have cloned https://github.com/JelteF/derive_more and added this patch section to Cargo.toml:

[patch.crates-io]
derive_more = { version = "1.0.0-beta.6", path = "../../derive_more" }

Then I searched with git bisect between v1.0.0-beta.6 and v1.0.0-beta.7 and traced the problem to commit JelteF/derive_more@162535e

Corresponding PR:
JelteF/derive_more#371

@link2xt
Copy link
Collaborator Author

link2xt commented Aug 3, 2024

Now going to reproduce this in https://github.com/n0-computer/iroh repository, they also have derive_more locked to 1.0.0-beta.6.

@link2xt
Copy link
Collaborator Author

link2xt commented Aug 3, 2024

This is actually fixed worked around in n0-computer/iroh#2578, we just need to wait for a new iroh release.

@link2xt
Copy link
Collaborator Author

link2xt commented Aug 3, 2024

I also opened upstream issue JelteF/derive_more#392

@link2xt
Copy link
Collaborator Author

link2xt commented Aug 3, 2024

Will close this for now, we are not actually interested to update it, this PR is just for debugging.

@link2xt link2xt closed this Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant