fix(iroh-net): Fix a compiler error with newer derive_more versions
#2578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flub
approved these changes
Aug 2, 2024
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2578/docs/iroh/ Last updated: 2024-08-02T09:15:24Z |
This was referenced Aug 3, 2024
|
This is caused by JelteF/derive_more#371 |
|
I opened an upstream issue JelteF/derive_more#392 |
matheus23
added a commit
that referenced
this pull request
Nov 14, 2024
…#2578) ## Description <!-- A summary of what this pull request achieves and a rough list of changes. --> The `#[derive(Debug)]` used to generate an impl like this: ```rust #[automatically_derived] impl<'a> ::core::fmt::Debug for Accept<'a> where quinn::Accept<'a>: ::core::fmt::Debug, Endpoint: ::core::fmt::Debug, { // ... } ``` But `quinn::Accept` doesn't implement `Debug`. ## Breaking Changes <!-- Optional, if there are any breaking changes document them, including how to migrate older code. --> None ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> I'm... Really stumped on what changed in `derive_more`. When I expand the macro, in both versions there's a `Debug` bound on `quinn::Accept`, which just can't be right... Anyhow. ## Change checklist - [X] Self-review. - ~~[ ] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant.~~ - ~~[ ] Tests if relevant.~~ - [X] All breaking changes documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
#[derive(Debug)]used to generate an impl like this:But
quinn::Acceptdoesn't implementDebug.Breaking Changes
None
Notes & open questions
I'm... Really stumped on what changed in
derive_more. When I expand the macro, in both versions there's aDebugbound onquinn::Accept, which just can't be right... Anyhow.Change checklist
[ ] Documentation updates following the style guide, if relevant.[ ] Tests if relevant.